Repository navigation
Face-to-face group: + Add entry, pick Bots, live joined roster, Enter chat (#92) - #96
Conversation
The inline Join with a number form was hard to find and only brought one Bot. + Add now opens a Face-to-face group screen: multi-select Bots, join by the 6-digit number (one social/face-join per Bot), a live roster with countdown, and Enter chat. Several local Bots in the same room are tracked together on leave. Co-authored-by: Danyang Chen <birfychen@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 24417d10cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| function rememberAsBot(meta, handle) { | ||
| const key = handle ? norm(handle) : '' | ||
| const asBots = asBotsOf({ asBots: [...asBotsOf(meta), key] }) |
There was a problem hiding this comment.
When applyFaceSnapshot is called from startFaceRoom (or while recovering a server room with no local metadata), handle is undefined and key is ''; this line still passes it to asBotsOf, where norm('') becomes the truthy but invalid handle '@'. Consequently every normal Enter-chat flow persists '@' in asBots, and the later Leave request sends it in the bots array alongside the real handles; Bot Social's handle validation can reject that entire request, leaving the Bots and their room-only identities stuck in the room. Only append key when it is nonempty, and reject normalized '@' values.
Useful? React with 👍 / 👎.
…' Bots panel (#92) (#100) Follow-up to #96 / #93 / #91. - **Face-to-face group** is now an entry in the global sidebar **+** (new-chat picker), right after New group chat, via a new `flybot.new-chat.action` slot (patch layer). It also stays in Friends' Bots + Add and works while the roster is loading. - **Removed Bots stay gone:** a hide is forgotten only after two consecutive successful non-legacy roster fetches without that handle (or an explicit revoke); hidden handles are kept out of `flybot.remote.publish`, so persisted remote chats do not return in the sidebar, the send-to picker or mentions. Home-level rows are filtered the same way. - **Performance:** parallel mount, stale-while-revalidate roster (Refreshing\u2026 instead of blocking Loading\u2026), keep-alive HTTP, non-blocking grant listing, slower/paused polling. - Tests, bundle check, patches check, CHANGELOG updated. --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Closes #92.