Repository navigation
feat(rooms): group link with no deadline for anyone until withdrawn; Members-card layout; Join-or-create entry; link rooms keep their name (#892) - #893
Merged
Conversation
…hdrawn; Members-card layout; Join-or-create entry; link rooms keep their name (#892)
Collaborator
Author
|
Verdict: PASS at dc8d5dd Focused review of the whole diff vs origin/main (c90af02), against the owner's asks of 2026-10-24 and Birfy/bot-social#66 (merged as 929d390):
Ran:
Notes (non-blocking): a second stranger home on the same link is covered by the unit tests, not the live run. This review is not merge authority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #892. Part of #853 (owner decisions 2026-10-24).
What changes, owner asks of 2026-10-24 00:32–00:45 Asia/Shanghai:
929d390), which stores no deadline and keeps one claim per home.room-membership.js): a link records every home it seated (homes, read throughhomesOf; older records keepacceptedBy). Withdraw setswithdrawnAt: nobody new joins, the seats it made stay (owner decision on A local-room invite link cannot be redeemed by a home that cannot already reach the inviter (cross-repo: claim + connector exception) #853 point 3). A guest that leaves or is removed ends only its own home's claim at the server (endClaim); deleting the room revokes withendClaims.seatByTicketreadsclaimersand answers from the claim that brought the asker.claimedmeans this home already joined, said as such, never "someone else joined".roomTitle): sidebar, header, drawer, brand show "Trip plan"; "Shared room from Ann" stays as the row's hover and the Shared tag's title. A friend-shared room with no link keeps today's title.Plugin copy now goes through core's
t()(__flybot__.t), so the zh UI reads the Members-card and dialog copy in Chinese.Tests:
TZ=UTC npm run verifyexit 0 (core 1328, social 395, tree 125, timeline 125, scripts 332, interop 37, live-e2e 16). Rewritten:core/test/room-ticket-seat.test.js(fake server now multi-claim, no deadline; withdraw keeps the seat, removal ends that home's claim, room delete ends every home's),remote-room.test.js, social plugin tests for the row, the dialog and the new entry.No CHANGELOG/version edit (fragment in
changelog.d/). No risk label.