Skip to content

Add the fix-issue skill: one issue end to end (facts, red test, gates, PR, review loop, merge) - #78

Merged
hsliuustc0106 merged 1 commit into
mainfrom
fix-issue-skill
Oct 15, 2026
Merged

hsliuustc0106 merged 1 commit into
mainfrom
fix-issue-skill

Conversation

@hsliuustc0106

Copy link
Copy Markdown
Collaborator

Companion to .claude/skills/review-pr/SKILL.md: review-pr covers the Verifier stage; this walks the whole loop an agent runs for one issue, as proven on #71 → PR #74:

  1. Establish the facts (crop the screenshot; file the issue first if needed), confirm scope.
  2. Worktree + environment, including the gotchas a fresh worktree hits (harness node_modules symlink or DSH_HARNESS, HTTPS push timeouts → SSH URL).
  3. Fail-without-change: test red at base, green at the tip, evidence kept for mechanical re-verification.
  4. Every gate at the linked tip (build, test, --check, lint + arch-docs, patches generate/check), topics.json for first-touch files, lint warnings compared against base.
  5. PR shape with Verifier-honest verification section.
  6. Independent review loop per review-pr — tip advance voids the PASS; outside-the-diff root causes become follow-up issues at once.
  7. Merge gate (same tip, agreement or waiver, maintainer's go) and cleanup.

Also adds item 8 to the AGENTS.md iteration loop pointing at it.

Docs-only (.claude/ + AGENTS.md): no gates apply locally; CI runs on this PR. Not run: everything code-shaped — nothing code-shaped changed.

The #71 loop (facts, worktree, red test, gates, PR, independent review,
merge on green) worked but lived only in this session. Write it down as a
skill beside review-pr, including the environment gotchas a fresh worktree
hits (harness node_modules, HTTPS push timeouts, screenshot attachments,
patches topics), and point at it from the iteration loop.
@hsliuustc0106
hsliuustc0106 merged commit 26e2414 into main Oct 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant