Repository navigation
Show every Bot at work in a group as one row with its step - #548
Merged
Merged
Conversation
The group's member dock drew members at work here as left rows, but work elsewhere as a centered event line, and the round's speaker as a second row in the transcript; rows said only "On it" or the tool's phrase. Now the dock is the one place: the speaker leads the rows, the summary line has the rows' shape and time, and each row names the step the running call acts on (owner-only work.bots step) or the tool. Fixes ThinkFlowLab#546
Collaborator
Author
|
Self-review (owner's reviewer agent, review-pr; self-PASS per review-policy Checked:
Tip SHA: 8c1e00e
|
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
Birfy
added a commit
to Birfy/FlyBot
that referenced
this pull request
Oct 20, 2026
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #546
Owner decision 2026-10-20 20:21: urgent fix of the group status rows.
Root causes
WorkRows in the member dock (member-status.js), but work elsewhere / overflow went onSummaryLine, a.bt-eventline whosejustify-content:centerpushed it toward the middle/right, and the round's current speaker was excluded from the dock (splitBusy) and drawn instead as a second.bt-activityrow inside the transcript (cells.jsGroupReplies), without elapsed time.workViewsenttool), andworkPhrasefell back to "On it" for any tool without a phrase.turn/endclears the live entry, client pollsworkevery 1.5 s); the transcript speaker row relied on a separate room-progress poll and is now gone.Change
splitBusyputs the speaker first among the rows;GroupRepliesno longer draws a pending row.SummaryLineis a.bt-mw-rowof the same shape and column with the first worker's elapsed time.workViewaddsstep(newest running call's command / pattern / query / url / path, else description; one line, ≤80 chars) to the owner-onlywork.botsview, not towork.roomsthat other members of a shared group read. Rows readName · Running shell commands: npm test · 11m; a tool without a phrase readsUsing <tool>. zh strings added.Overlap note:
member-status.js,member-status.test.js,group-status.test.jsandtopics.json(0001-core-fixes) are also touched by the parallel Always-allow approval fix; the edits are in different functions/tests, topics entries are the same three files in the same topic.Verification (tip in the review comment)
ARCH_DOCS_BASE=upstream/main TZ=UTC npm run verify→ pass (core 1114/1114, plugins all pass, arch-docs OK, patches check OK, build-client check OK); no new lint warnings in touched lines.packagejob locally (pack/typecheck/actionlint); visual check in a real browser / Desktop; owner's live instance.