Skip to content

Past rooms: list everyone, show each row's time, open from the row, remember the fold - #463

Merged
Birfy merged 2 commits into
ThinkFlowLab:mainfrom
Birfy:fix/304-face-room-titles-past
Oct 20, 2026
Merged

Birfy merged 2 commits into
ThinkFlowLab:mainfrom
Birfy:fix/304-face-room-titles-past

Conversation

@Birfy

@Birfy Birfy commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Fixes #304

What / why (per the Owner decision on #304, 2026-10-20)

  • Titles list everyone. A home that stayed (status Closed) stored its Past row from Bot Social's live member list, so the person who left vanished ("Face-to-face · SelfA0056 · 482915" while the header showed both). faceRoomTitle now takes the snapshot's members plus every participant the hosted room ever had (as the core title does, Face-to-face: avatars and room title differ per home (regressions of #137/#172); Leave is abrupt and not seen by the peer #182), and viewHostedFace for a closed/left room lists all participants (left: true on who had left; opening a dropped room seats only the others again). Rows stored before this are refreshed from their hosted room.
  • Each row shows its time (data-flybot=face-time): endedAt (set once by rememberPastFace), else start/creation time. Today 14:05, an earlier day Oct 19; hover shows Ended Oct 19 14:05.
  • The whole row opens the room (click, or Enter/Space; role=button); the separate Open button is gone.
  • The Past rooms fold remembers open/closed across reload (localStorage flybot.social.pastRoomsOpen, failures fall back to folded).

Test

  • New/updated tests in plugins/social/test/social.test.js: host test (last peer leaves → Past row named Danyang, Bob, Bob's Bot left: true, stable endedAt across polls), row time, row click/keyboard open with no Open button, fold persistence, title with a member who left. 7 of them fail on main.
  • ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1017, social 279, tree 80, timeline 80, scripts 88, interop 37, live-e2e 16; 0 failures).
  • Not run: live two-home self-test on the Mac instances.

Risk tier: T3 (estimate; the controller sets the label). Touches plugins/social/src/**.

@Birfy

Birfy commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Self-review: PASS
Tip SHA: d4d414a
Ran:

@Birfy Birfy added the awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip label Oct 20, 2026
@Birfy
Birfy added this pull request to the merge queue Oct 20, 2026
Merged via the queue into ThinkFlowLab:main with commit 48975f9 Oct 20, 2026
8 checks passed
@Birfy
Birfy deleted the fix/304-face-room-titles-past branch October 20, 2026 00:19
@Birfy Birfy removed awaiting-approval PR is green and waits for the maintainer's approval (T2/T3) or a review PASS at its tip agent-pr Pull request opened by an agent labels Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:social Friends, invites, grants, Bot Social area:ui Web/desktop UI and copy bug Something isn't working

Projects

None yet

1 participant