Repository navigation
Past rooms: list everyone, show each row's time, open from the row, remember the fold - #463
Merged
Merged
Conversation
Collaborator
Author
|
Self-review: PASS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
What / why (per the Owner decision on #304, 2026-10-20)
faceRoomTitlenow takes the snapshot's members plus every participant the hosted room ever had (as the core title does, Face-to-face: avatars and room title differ per home (regressions of #137/#172); Leave is abrupt and not seen by the peer #182), andviewHostedFacefor a closed/left room lists all participants (left: trueon who had left; opening a dropped room seats only the others again). Rows stored before this are refreshed from their hosted room.data-flybot=face-time):endedAt(set once byrememberPastFace), else start/creation time. Today14:05, an earlier dayOct 19; hover showsEnded Oct 19 14:05.role=button); the separate Open button is gone.localStorageflybot.social.pastRoomsOpen, failures fall back to folded).Test
plugins/social/test/social.test.js: host test (last peer leaves → Past row namedDanyang, Bob, Bob's Botleft: true, stableendedAtacross polls), row time, row click/keyboard open with no Open button, fold persistence, title with a member who left. 7 of them fail on main.ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core 1017, social 279, tree 80, timeline 80, scripts 88, interop 37, live-e2e 16; 0 failures).Risk tier: T3 (estimate; the controller sets the label). Touches
plugins/social/src/**.