Repository navigation
Mark replies that left through per-pair Auto-send as Auto-sent (part of #417) - #437
Merged
Merged
Conversation
… turn (part of ThinkFlowLab#417) The social middleware's allow says autoSent (with the recipient) when Auto-send for that pair skips its hold; the host keeps that mark by the turn the reply answers (state.flybot.autoSent, last 200, no text) and lists it in heldReplies as status auto. The chat draws a plain bubble with a quiet Auto-sent to <person> where ThinkFlowLab#418 shows Sent.
6 tasks
Collaborator
Author
|
Self-review (Birfy) Tip SHA: e0962ab Reviewed the diff:
Verdict: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #417 (owner decision 2026-10-19 17:21: show an Auto-sent marker on messages a Bot sent through per-pair Auto-send from #433).
Risk tier: T3 (touches
plugins/social/src/social.jsand the host hook seamcore/src/host/hooks.js).What it looks like
A Bot reply that left without a card because Auto-send is on for that pair now shows a plain (normal, non-dashed) bubble with a quiet meta line under it:
Same place and style as #430's
Sent to …/Not sentlines, no buttons. The wait badge and sidebar preview treat it as sent.How
social.js: when the hold is skipped only becauseapprovalFor(from, home) === 'auto', the middleware returns{ action: 'allow', autoSent: true, recipient }.hooks.js: anallowwithautoSenton an auto-reply that carriesmeta.replyInis recorded by turn instate.flybot.autoSent(id, by, botId, sessionId, turn, to, recipientName, at; last 200; no message text).rt.heldRepliesOflists these asstatus: 'auto', so Held reply to a friend: held in place, decision on the bubble, Sent / Not sent after (#418) #430's channel view (heldReplies) carries them unchanged.pendingCountonly counts pending.held-reply.jsdraws theAuto-sent to {to}note;text.jsunsentReplyTurnstreatsautoas sent; i18n string added.flybot.d.ts, docs (social, core-host, plugin-runtime, core-client), changelog fragment.Only per pair, only replies on a tagged turn; a plain request or a home without Auto-send is not marked.
autoSentconfers nothing, it is display only.Overlap
Does not touch
channel.js/authz.js/models.js(#434) orindex.js/model-menu.js/sidebar.js(#435). Shared files with them are only generated ones (core/client.js, patches) plus docs/i18n in different sections.Tests
core/test/held-reply.test.js: auto state rendersdata-state="auto",Auto-sent to SelfB1238, no buttons;unsentReplyTurnsignores it.plugins/social/test/social.test.js: with Auto-send on fora↔@bob.home, a reply is allowed and listed asautowith recipient Bob,pendingCount0; botbstill holds; a plain request is not marked.ARCH_DOCS_BASE=upstream/main TZ=UTC npm run verify✅,node scripts/lint-plugins.mjs social✅, patches check ✅, check-pack ✅, tsc strict types ✅, changelog check ✅.