Repository navigation
A friend's Bot sidebar row: name and owner on one line, a second line like own rows - #389
Conversation
… like own rows (part of ThinkFlowLab#384) Docs-not-needed: core/test/flybot-client.test.js only gains a sidebar row test; the sidebar is documented in core-client.md, updated here.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7b306fe26
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // A friend's Bot row (#384): its name, then its owner, on one line like every other row; the | ||
| // second line is the preview, or "Friend's Bot" before the first message. The full title is on hover. | ||
| const rowName = remoteRecord ? cleanPeerName(bot.name, shown) : shown | ||
| const owner = remoteRecord ? ownerNameOf(remoteRecord) : '' |
There was a problem hiding this comment.
flybot.remote.publish allows homeName and owner to be omitted, and core/src/host/hooks.js explicitly supports plain per-Bot identities, but ownerNameOf(remoteRecord) returns '' for a valid plain handle such as @alice.bot. In that case this new markup omits bt-row-owner, so two remote chats named Helper lose the textual disambiguator that the previous shown title—and the still-computed remoteBotTitle—provides as Helper · @alice.bot's Bot; use the same handle/home fallback here so these valid rows still show an owner identifier.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 5fe25c0: with no owner name, the row shows the cleaned handle (@alice.bot) in the owner slot, so two "Helper" rows stay apart.
… owner goes Codex P2 on ThinkFlowLab#389. Docs-not-needed: same row as documented in core-client.md; the fallback is a one-line detail.
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Part of #384
What changed
Helper SelfB0023 🌐,Chief SelfA0023 🌐. The two-line title clamp is gone, soHelper · SelfB0023's/Botno longer wraps. The fullremoteBotTitle("Helper · SelfB0023's Bot") is the hover text and the row's label.--bt-ink-2instead of the faint--bt-ink-3.Not in this PR (left open on #384): the chat header / picker / approval cards still use the "
<name> · <owner>'s Bot/<owner>'s Chief" title (one format everywhere touches face-room alias routing, #305); the hover band inset seen at 150% zoom (not reproduced here without a two-home bench); and an avatar that matches one of my own Bots.Risk: client sidebar markup and CSS only (
core/src/client/sidebar.js,styles.js).Docs-not-needed: core/test/flybot-client.test.js only gains a sidebar row test; the sidebar is documented in core-client.md, updated here.
Verification at the tip
Tip SHA: 5fe25c0
Ran:
TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify(Node 24), green. New source test incore/test/flybot-client.test.js(row name/owner spans, second-line fallback, hover title, owner/marker CSS, zh key); the #304 test now asserts no sidebar row has a two-line clamp.Not run (and why): no screenshots of a two-home bench in this run.