Repository navigation
Face-to-face room rows stay on one line with the full title on hover (part of #304) - #376
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // A face room's people mark. It is not a friend's Bot marker, so the row keeps one line (#304). | ||
| function FaceMark() { | ||
| return h('span', { className: 'bt-row-remote', title: t('Face-to-face'), 'aria-label': t('Face-to-face') }, | ||
| return h('span', { className: 'bt-row-remote bt-row-face', title: t('Face-to-face'), 'aria-label': t('Face-to-face') }, |
There was a problem hiding this comment.
This commit changes paths owned by the core-client, plugin-runtime, and social subsystems, but includes neither a corresponding docs/subsystems/ update nor a Docs-not-needed: trailer. Running ARCH_DOCS_BASE=4bfade5^ node core/scripts/check-arch-docs.mjs at this commit reports the changed client and social files and exits 1, so the required CI gate cannot pass until the affected subsystem docs are updated or a justified trailer is added.
AGENTS.md reference: AGENTS.md:L94-L94
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 09c100e: core-client.md, social.md and plugin-runtime.md now describe the one-line face-room row and hover titles; arch-docs passes and CI is green at that tip.
Part of #304 (item 5) and #173 (sidebar truncation). Not closing #304: items 4 (closed tab title) and the live check of item 5's "row vanished until reload" stay open.
Problem
A face-to-face room's sidebar row wrapped to two lines: the face-room people mark uses the
bt-row-remoteclass, and the two-line clamp from #176 is keyed on that class (it is meant for a friend's Bot row). Neither the row nor a Past rooms entry had the full title on hover, so a cut title (Face-to-fa…) could not be read.Change
core/src/client/sidebar.js:FaceMarkalso carriesbt-row-face;RoomRowsetstitleto the room's full title.core/src/client/styles.js: the two-line clamp applies to.bt-row-remote:not(.bt-row-face), so a face-room row keeps one line with an ellipsis. A friend's Bot row still wraps to two.plugins/social/client.js: the Past rooms entry's name has the full title as hover text.core/client.js,patches/ds-bot/(generate, then check). Changelog fragment.No status chip was added to the live row: a live room is already set apart by the people mark and being in the main list, while ended rooms move to Past rooms, which has chips. Say if you want one.
Tests
core/test/flybot-client.test.js: new source test for the class, the rowtitleand the clamp selector (fails on main).plugins/social/test/social.test.js: the Past/face card name carriestitle(fails on main).TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify(Node 24) green.Client-only CSS/markup; expected tier T1/T2 (core client + plugin client).