Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 847a01d59a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // The footer entry to Settings > Connectors, where a Bot's apps are connected. | ||
| export function ConnectApps({ wide, actions }) { |
There was a problem hiding this comment.
This changes files owned by the core-client and plugin-runtime subsystem docs, but neither subsystem document is updated and the commit message has no Docs-not-needed: trailer. Running ARCH_DOCS_BASE=81980061aba73e2a8e41c441379abe46bb722f6f node core/scripts/check-arch-docs.mjs fails for these files, so npm run lint and npm run verify cannot pass as claimed; update the applicable docs or add the required trailer.
AGENTS.md reference: AGENTS.md:L92-L94
Useful? React with 👍 / 👎.
847a01d to
b1de3fa
Compare
|
Folded into #323 at Danyang's request (the footer button change is cherry-picked there, plus a Plugins row in the account menu so the plugin panel stays reachable). Closing without merging. |
The sidebar footer button used to open the shell's plugin panel (
selectPanel('plugins')). It now callsactions.openConnectors()(Settings > Connectors, the same call the account menu uses) and reads Connect apps / 连接应用. The icon is unchanged.core/src/client/sidebar.js,index.js,i18n.js:ConnectPluginsrenamedConnectApps; theConnect pluginskey is replaced byConnect apps. No other mention of the old text exists in README, docs or tests.core/client.jsandpatches/ds-bot/regenerated.flybot-client.test.jschecks the click handler, the label and the zh entry.docs/subsystems/core-client.mdandplugin-runtime.mdupdated for the arch-docs gate.Plugin panel reachability: the Bot surface no longer has any entry to the shell's plugin panel. The account menu has no Plugins row (its code comment mentions one, but none exists), and the command palette and Settings pages have none either. The panel is still reachable through Account menu > "Switch to classic Agent mode", which restores the shell's own sidebar. If you want a direct entry back (for example a "Plugins" row in the account menu), that is a small follow-up.
Ran at the tip:
ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify(exit 0). Not run: pack check, typecheck, smoke test.