Repository navigation
fix(ui): show hover gear on own Bot sidebar rows too - #298
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e143c2de71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type: 'button', className: 'bt-row-settings', 'aria-label': t('Bot settings'), title: t('Bot settings'), | ||
| // Hover/focus gear on every wide row (#276/#173): own Bots and friends' Bots alike. | ||
| const settingsLabel = bot.remote ? t('Bot settings') : t('Edit Bot') | ||
| const settings = wide ? h('button', { |
There was a problem hiding this comment.
With motion enabled, when activity reorders the wide sidebar, useListGlide animates every matching [data-bot-id]. Enabling settings for own Bots sends them through the wrapper at line 96, which has the same ID as the inner row button at line 82, so the parent and child both receive the translation and their transforms compound; the row starts twice the measured distance away while its gear starts at the correct old position. Keep the glide ID on only one element for each wide own-Bot entry.
Useful? React with 👍 / 👎.
Friends' Bots already had a bt-row-settings gear; own Bots did not, so hover affordance was inconsistent. Wide mode now wraps every Bot row and opens Edit Bot (own) or Bot settings (friend).
Part of #276 (item 4). Also covers the gear consistency note in #173.
Own Bot rows in the wide sidebar never showed the hover gear; only friends' Bots did (
wide && bot.remote). Every wide Bot row is now abt-row-wrapwithbt-row-settings: Edit Bot for an own Bot, Bot settings for a friend's. Hover/focus CSS unchanged.Left open on #276 / #275: sticky NEW divider (needs live repro).
Ran:
TZ=UTC ARCH_DOCS_BASE=upstream/main npm run verify(will run after push). Changelog fragment added. Docs: core-client.md. Nothing deployed.