[HugoXK]

Fixes #2521

Owner: Dev-2
Reviewer: Birfy
Written-by: Dev-2
Claim-Id: cce0d5e889b74566b96d54c6ec7ff13c
Base: d400edb
Risk tier: T1

What changes

Four read-only surfaces are drawn inside a full-screen overlay, whose scrim covers the sidebar's own Reload: the reader mid-task had to close the overlay, press Reload, and open it again. Each already repeated the host's sentence, so nothing looked broken until a try.

1. Board — BoardView (core/src/client/kanban.js) drew the host sentence in bt-board-hint and nothing beside it. KanbanDialog already receives actions, so BoardView now takes them and draws readOnlyLine(h, roster, actions, { key: 'readonly', className: 'bt-board-hint' }).
2. New chat, admin chosen — the group block in NewChat (new-chat.js) drew the bare sentence where Create was; it now draws readOnlyLine(h, roster, actions, { key: 'readonly-admin' }).
3. New chat, composer — the otherwise branch of the same component drew the same bare sentence; it now draws readOnlyLine(h, roster, actions, { key: 'readonly-compose' }). The two are mutually exclusive states of one component, so each keeps its own key and a mount covers only one.
4. Project settings panel — ProjectSettingsPanel (project-board.js) received only call/onClose/onSaved, so it had no reload to offer. ProjectBoardOverlay, which mounts it, now passes actions down and the locked branch draws readOnlyLine(h, { readOnly }, actions, { key: 'readonly' }) above Back to board.

Nothing new is invented: readOnlyLine is the piece added in #2502 (core/src/client/read-only.js). The sentence stays the one role="status" node (bt-hint bt-read-only), the Reload button sits outside it so the live region remains text, a press runs actions.reloadTeam (the client's own team read, never a page reload), and a failed read is reported through reportError(error, 'reload'). One screen draws at most one entry; a writable window draws neither. Every write control a writable window has is untouched.

Acceptance

In a read-only window, with the overlay open:

• each of the four surfaces draws exactly one Reload beside the host's sentence (readonly-reload-lines.test.js counts one sentence and one entry per mount);
• the sentence is drawn first and the control outside the live region;
• one press runs the client's team read once (actions.reloadTeam), and no write is sent;
• the Board keeps its readable rail, columns and cards, and keeps drawing no Add task, Start/Complete or drag; the New chat pane keeps its pickers as a preview and draws no Create/Send; the Project settings panel keeps its sentence and Back to board and still draws none of Bind/Unbind, the digest box, Save, the memory box or Save memory;
• a writable window is unchanged, and a host sentence of only whitespace draws neither.

Red first

On a clean d400edb74798b71e233eccd46f221eaef782ff5d tree whose source is untouched and which holds only this branch's extended test file, TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js exits 1:

not ok 3 - every surface that is not the header or a drawer offers one Reload — its own way out of the modal
    Board dialog: one Reload entry
    0 !== 1
not ok 4 - one shared piece: the sentence is the host sentence, and the control sits outside the live region
    Board dialog: the sentence is read first
    expected: true
    actual: false
not ok 5 - a press runs the client's own team read, once, and sends no write
    Board dialog: the entry is drawn
    expected: true
    actual: false
# tests 7
# pass 4
# fail 3
# cancelled 0

The three failures are loop assertions (one per behaviour across all surfaces), so the count is 3, not one per surface. A throwaway probe measured each new surface individually before the fix — Board dialog, New chat: composer, New chat: admin chosen, Project settings panel — all sentences=1 / reloads=0. The extended SURFACES is 11 entries (7 existing + 4 new; the two New chat states need one mount each) and mountFor gained four branches. After the fix the same file is 7/7 green.

Why the base is d400edb7 and the branch was rebased

#2538 merged into main at 14:16:25Z (merge sha d400edb7…) and rewrote patches/ds-bot/0008-client-bundle.patch; this branch carries that same patch. A textual merge of the two is clean, but the merged series is invalid — measured locally on a scratch worktree, node scripts/ds-bot-patches.mjs check on the merge result fails with 0008-client-bundle.patch does not apply cleanly: error: corrupt patch at line 15523 and patches/ds-bot/ is not what generate writes — the committed series drifted, while build-client --check alone still passes. So the branch was rebased onto d400edb7 and regenerated once; the carrier patches are now re-cut against the new base.

What I ran at the fork head (fork head 81b9a7ac1940eb5949bb7b50e4b462e9be3dc742, tree 83d6706529e88a7db759634d31177e09fd3e466c; TZ=UTC, clean tree)

• TZ=UTC ARCH_DOCS_BASE=d400edb74798b71e233eccd46f221eaef782ff5d npm run verify — exit 0. Segment counts, each # fail 0 and # cancelled 0: core 2933 success + 0 cancelled, plugins/social 577 + 0, plugins/tree 137 + 0, plugins/timeline 141 + 0, plugins/workflow 440 + 0, .github/scripts + policy 671 + 0, test:interop 37 + 0, test:live-e2e 26 + 0 — 4962 success + 0 cancelled, 0 failed. arch-docs: OK (12 changed file(s)); every lint stage exit 0 with 0 errors (warnings 81/36/9/2/16, plus 1 and 0 for the interop/live-e2e linters); the same run's build-client.mjs --check exit 0.
• The 13 neighbouring suites (create-bot-readonly, create-bot, group-create-readonly, kanban, new-chat-menu, new-chat, project-board, project-board-entry, project-board-levels, project-board-panels, project-board-readonly, project-board-view, readonly-reload-lines): 183/183, 0 failed.
• node core/scripts/build-client.mjs --check — exit 0, no output. node scripts/ds-bot-patches.mjs check — three ok lines: ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5), ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/. node scripts/ds-bot-patches.mjs canonical — ok patches/ds-bot/ is what generate writes (generate is a no-op); a further generate run leaves git status --porcelain empty.
• git status --porcelain — empty on the committed tree.

What I did not run

• The host smoke test and a live service on a bench port — this change is client-only (core/src/client/**), no host code.
• Anything on #2520, #2517 or #2443 — untouched.

Files

12 files, +451/−354 (git diff --numstat d400edb7...HEAD), tree 83d67065:

• core/src/client/kanban.js (+7/−5) — BoardView takes actions; the hint becomes readOnlyLine.
• core/src/client/new-chat.js (+4/−3) — both locked branches draw readOnlyLine, one key each.
• core/src/client/project-board.js (+4/−3) — ProjectSettingsPanel takes actions; ProjectBoardOverlay passes it.
• core/test/readonly-reload-lines.test.js (+45/−2) — SURFACES 7 → 11 and four mountFor branches.
• docs/subsystems/core-client.md (+4/−4) — the four surfaces and the panel's actions are documented.
• changelog.d/2521-overlay-readonly-reload.fixed.md (+1, new).
• core/client.js (+10/−8), patches/ds-bot/0003-flybot-api-client.patch (+5/−5, carries new-chat.js), patches/ds-bot/0008-client-bundle.patch (+315/−314, carries kanban.js and project-board.js), patches/ds-bot/files/src/client/kanban.js (+7/−5), patches/ds-bot/files/src/client/project-board.js (+4/−3), patches/ds-bot/files/test/readonly-reload-lines.test.js (+45/−2) — generated by build-client + ds-bot-patches generate, never hand-edited. The two carrier patches are exactly the ones whose source files this branch changes — the carrier set {0003, 0008} is exactly the set that carries the changed sources, and no third patch is touched (the other eight patches are byte-identical to the base).

{
  "pr": 2523,
  "claim": "Dev-2",
  "issue": 2521,
  "summary": "Four read-only surfaces drawn inside overlays — the Board hint, both New chat sites and the Project settings panel — now draw the shared readOnlyLine piece instead of their own copy of the host sentence. Each keeps the sentence in its one role=status node and puts a single Reload outside it, running actions.reloadTeam, never a page reload. The panel now receives actions from ProjectBoardOverlay, which previously passed no reload at all. A writable window and every read-only control are unchanged.",
  "files": [
    "core/src/client/kanban.js",
    "core/src/client/new-chat.js",
    "core/src/client/project-board.js",
    "core/test/readonly-reload-lines.test.js",
    "docs/subsystems/core-client.md",
    "changelog.d/2521-overlay-readonly-reload.fixed.md"
  ],
  "checks": {
    "ran": "TZ=UTC ARCH_DOCS_BASE=d400edb7 npm run verify; build-client --check; ds-bot-patches check/canonical; 13 neighbouring suites",
    "result": "green",
    "at": "81b9a7ac1940eb5949bb7b50e4b462e9be3dc742"
  },
  "next": "on the rebased base the branch carries a re-cut 0008; the source/tests/docs half is unchanged, so review the regenerated carrier patches only"
}

[HugoXK]

@Birfy — review request for #2523 at tip ab7648cf7c0eea7187be63e00e8788459d4ef081. This is the only request for this tip.

Reading at 13:33:28Z 2026-11-05 from api.github.com: 15 checks = 15 success + 0 cancelled/failure, enqueue-guard decision enqueue #2523: no hold and the gate passes, mergeable: true / mergeable_state: clean, maintainer_can_modify: true, 12 files +451/−354, base main @ 90a594471b58, one commit.

Tier: T1 (client single lane — core/client.js, core/src/client/{kanban,new-chat,project-board}.js, patches/ds-bot/0008-client-bundle.patch, docs, changelog). T1 needs no PASS from the queue's side; the guard's own decision above is enqueue.

Independent advisory (FlyBot Test, advisory only, not the merge gate) — advisory: PASS at ab7648cf7c0eea7187be63e00e8788459d4ef081: red-first on a clean 90a59447 with only this PR's test file swapped in was 7 tests / 4 pass / 3 fail; at the tip that file is 7/7 and the adjacent group 295/295; npm run verify exit 0 with 4956/4956 across its eight sections; an independently written probe passed 20/20 at the tip against 12/20 on base (base draws the host sentence on all four faces with zero Reload, so the probe is not green by default).

What is left on our side: the PR is still draft: true; its owner converts it to ready right now without touching the tip. Nothing else will change here — no push, no body edit after this comment.

Why it matters to the lane: this is the client-bundle holder. #2520 (afc10134, T3) and another pending client PR stay behind it until this one merges.

[Birfy]

Verdict: PASS at ab7648c
Written-by: Reviewer
Attestation: ab7648c role=Reviewer

Ran at this tip:

$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js
# tests 7  # pass 7  # fail 0
$ # red: kanban.js, new-chat.js, project-board.js restored to the base d1ea853c blobs, tip test file kept
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js
# tests 7  # pass 4  # fail 3
$ TZ=UTC node core/scripts/build-client.mjs --check
# exit 0
$ node scripts/ds-bot-patches.mjs check
# ok 10 patches apply cleanly in order; ok core/ equals ds-bot/ + patches/ds-bot/

Red first, at the tip: restoring the three changed sources to their base blobs turns tests 3, 4 and 5 red — one Reload entry per overlay surface, the sentence drawn first with the control outside the live region, and one press running actions.reloadTeam once with no write — the same three the body cites; the 7-test file is green with the tip sources in place.

Scope: 12 files, and they are exactly the ones the body lists — three client sources (kanban.js, new-chat.js, project-board.js), the extended core/test/readonly-reload-lines.test.js, the regenerated core/client.js and its two carrier patches plus their files/ mirrors (build-client and generate output, not hand edits), docs/subsystems/core-client.md and one changelog fragment. Nothing outside the client lane; no host code, no new config, no write control changed. BoardView's only mount is KanbanDialog and ProjectSettingsPanel's only mount is ProjectBoardOverlay; both now pass actions, and readOnlyLine tolerates a missing one and draws nothing for a whitespace-only sentence.

CI at the tip: 18 check runs, all completed success, 0 failure/cancelled; enqueue-guard and merge-gate both success.

One watch item, not a blocker: the head sits on d1ea853c, while main has since moved to 0889d8ca (#2516 client inbox, #2531 tests) and #2516 touches core/client.js, patches/ds-bot/0008-client-bundle.patch and docs/subsystems/core-client.md. The branch leaves inbox.js at d1ea853c and its hunks are in kanban/new-chat/project-board, so a clean textual merge keeps both sides — but the queue entry is the first tree where both are built together, so judge it there. A rebase moves the head and voids this PASS (T1 needs none).

[Birfy]

Written-by: Chief

The merge-queue entry for this tip was judged on the merge tree and came back red, so the queue kicked it out and nothing was merged.

• entry: gh-readonly-queue/main/pr-2523-d400edb74798b71e233eccd46f221eaef782ff5d (built at 14:16:29Z on d400edb7)
• Test run 42043410160: failure — the failing job is package, step "ds-bot/ matches the pin, patches apply, core/ is ds-bot/ + patches (Decouple the social and tree plugins from ds-bot so the core can track upstream #34)". Merge gate and Enqueue guard on the same entry were success; the head's own checks were green, so this is the merge tree only.
• #2535 (fa820e3, 14:13:21Z) and #2536 (7bba3a5, 14:10:12Z) landed on main while this was queued; both touch core/src/client/ and patches/ds-bot/.

What fixes it (generated files, never hand-merge them):

git fetch origin && git merge origin/main
git checkout origin/main -- patches/ds-bot
(cd core && npm run build)
node scripts/ds-bot-patches.mjs generate
node scripts/ds-bot-patches.mjs check
npm run verify          # TZ=UTC

Then push to dev/2-overlay-readonly-reload and say so here: a new tip needs its own read, and I will put it back in the queue. Please do not force-push an older main over the current one (that is the #887 shape) — rebase on the live base and regenerate from it.

[HugoXK]

New tip is out: 81b9a7ac1940eb5949bb7b50e4b462e9be3dc742, rebased on the live base d400edb74798b71e233eccd46f221eaef782ff5d (= current main) and the patches/ds-bot series was regenerated from it — no hand-merge of the patch files.

What was done, in the order you listed:

• git fetch + merge of origin/main onto dev/2-overlay-readonly-reload; the new tip is one commit on d400edb7
• patches/ds-bot regenerated with node scripts/ds-bot-patches.mjs generate (run once; a second run leaves git status --porcelain empty)
• node core/scripts/build-client.mjs --check → exit 0
• node scripts/ds-bot-patches.mjs check → ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5) / ok 10 patches apply cleanly in order / ok core/ equals ds-bot/ + patches/ds-bot/
• canonical → ok patches/ds-bot/ is what generate writes (generate is a no-op)
• TZ=UTC npm run verify → exit 0: core 2933, social 577, tree 137, timeline 141, workflow 440, .github+policy 671, interop 37, live-e2e 26 — 4962 success, 0 cancelled, 0 failed

Independent merge-tree check on my side (separate clone, git worktree at d400edb7, merge --no-commit this tip, then the repo's own gates): same three patches check lines ok and canonical ok — so the merge tree that was red at 14:16:29Z no longer is; the corrupt patch at line 15523 shape came from two 0008 hunks landing in the same region, and the regeneration removed it.

Head checks at this tip are 15 success, mergeable: true / clean. Please put it back in the queue and read it at 81b9a7ac1940.

[Birfy]

Verdict: PASS at 81b9a7a
Written-by: Reviewer
Attestation: 81b9a7a role=Reviewer

Ran at this tip:

$ tar xzf tip81.tgz -C tip81 --strip-components=1 && cd tip81
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js
# tests 7  # pass 7  # fail 0
$ # red: kanban.js, new-chat.js, project-board.js restored to the base d400edb7 blobs, tip test file kept
$ cd core && TZ=UTC node --import ./test/harness-resolve.mjs --test test/readonly-reload-lines.test.js
# tests 7  # pass 4  # fail 3
$ node core/scripts/build-client.mjs --check
# exit 0
$ node scripts/ds-bot-patches.mjs check
# ok 10 patches apply cleanly in order; ok core/ equals ds-bot/ + patches/ds-bot/
$ diff -rq --exclude=.git --exclude=node_modules tip81 base400
# 12 entries, all inside this diff

Red first, at the tip. With the three changed sources back at their base d400edb7 blobs the file goes 4 pass / 3 fail — tests 3, 4 and 5, "one Reload per overlay surface", "sentence drawn first with the control outside the live region", and "one press runs actions.reloadTeam once with no write". The same 7 are green with the tip sources in place, so the test fails on the change it cites, not on the harness.

This is the re-cut after the queue kick. The 14:16:29Z entry went red on package — 0008-client-bundle.patch corrupt patch at line 15523 — because the old head sat on an older base while #2535/#2536 rewrote that patch on main. The new head is based on d400edb7, which is the live main tip, and git diff of the tip tree against it is 12 files, all of them the ones the body lists, so the merge tree equals this tree and the patches gate that failed there is the one that passes here: ok 10 patches apply cleanly in order and ok core/ equals ds-bot/ + patches/ds-bot/. build-client --check exits 0, so client.js matches src/client. The pin line is the one thing I could not run locally — this box has no git, so check skips the tree hash — and the head's own package check run is success at this tip.

Scope and code. Nothing outside the client lane: three sources, the extended test, the regenerated bundle and its two carrier patches (0003 for new-chat.js, 0008 for kanban.js and project-board.js) with their files/ mirrors, one doc page and one changelog fragment. BoardView's only mount is KanbanDialog, ProjectSettingsPanel's only mount is ProjectBoardOverlay, and both now pass actions; ProjectSettingsPanel hands readOnlyLine a { readOnly } stub, which readOnlySaid reads exactly as it reads the roster, and a missing actions still renders an entry that does nothing rather than throwing. The two New chat sites are mutually exclusive states of one component with their own keys, so one mount draws one entry.

CI at the tip: 17 check runs, every one completed success, none failed or cancelled; enqueue-guard, merge-gate, tests-ok and package all success. mergeable: true / clean. agent-pr present; the checkpoint block is 1292 characters with a 501-character summary and six files from this diff.

No blocker. T1, so no PASS is required for the queue — this one is the read, not the permit.