Repository navigation
fix(ui): tab title says closed for an ended face-to-face room - #251
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 633e7158a0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| // An ended face-to-face room (closed, or someone left) no longer lists people who are not in it (#250). | ||
| // A name the user chose is kept. | ||
| if (room && room.origin === 'face-to-face' && (room.face?.status === 'closed' || room.face?.status === 'left') && isAutoFaceTitle(room.name)) return 'Face-to-face · closed' |
There was a problem hiding this comment.
When an open face room disappears from Bot Social's list() response, pollFaceRooms records a closed entry in pastFaceRooms but never updates the hosted room (plugins/social/src/social.js:2267-2273), and openFaceRoom then returns that still-open hosted room before consulting the past entry (plugins/social/src/social.js:2426-2430). Opening that ended transcript therefore leaves room.face.status === 'open', so this predicate does not run and the tab still lists the former members; update the hosted status on disappearance (or otherwise account for the past-room state) before deriving the label.
Useful? React with 👍 / 👎.
Fixes #250
On B the tab title kept
Face-to-face · UiA1415, UiB1415 · Oct 18 11:00 — FlyBotafter A left (roomorigin: face-to-face,face.status: left, Members · 1).Decision. The auto-generated face title lists the members the room was created with. Once the room has ended (
face.statusisclosedorleft, the same test the sidebar uses for Past rooms) the tab saysFace-to-face · closed — FlyBot. A room name the user chose is kept; a running room is unchanged. The tab already re-reads on roster changes (#244), so it follows when the status flips.Tests.
core/test/branding.test.js: open room lists members;closedandleftread closed with no session change; a user-chosen name, a non-face room and a generic title behave as described.Tip 633e715. Ran:
ARCH_DOCS_BASE=upstream/main TZ=UTC npm run verify(exit 0: core, social, tree, timeline, scripts, interop, live-e2e), build-client regenerated, patches regenerated.Not run: a live two-home check of the tab title; smoke test.