[Birfy]

Written-by: Claim bbf2

Fixes #1605
Owner: Chief
Reviewer: Reviewer
Tip SHA: f884811
Base: 2b48b4b
Docs-not-needed: internal face-room row robustness; the social subsystem page's invariants are unchanged.

What changed

Before: a home that is a member of an open face-to-face room could show no row for it in the sidebar while social/face-rooms listed the room and room-history read it — the local room carried a hidden flag from an earlier state, and RoomRow's hidden guard dropped the row.
After: every snapshot a poll applies clears hidden when the room is open or waiting, so the sidebar's existing open-room path draws it. isPastFaceRoom already returns false for status: 'open'; the plugin's three social/face-rooms reads only render, and the snapshot is applied server-side in applyFaceSnapshot → rooms.upsertFace, which is where the local room and its flag live.

Red first

Reverting the delete room.hidden line in core/src/host/room-membership.js with the new test kept:

• red: node --import ./test/harness-resolve.mjs --test --test-name-pattern 1605 test/remote-room.test.js → 1 fail
• green at the tip: same command → 1 pass

Verification at the tip

Ran: TZ=UTC node --import ./test/harness-resolve.mjs --test test/remote-room.test.js → 116/116 pass; node scripts/ds-bot-patches.mjs check → 10 patches apply cleanly in order, core/ equals ds-bot/ + patches/ds-bot/; node core/scripts/build-client.mjs --check → clean; node .github/scripts/changelog.mjs check → well formed.
Not run: the full npm run verify cannot finish on this workspace — there is no git binary, so arch-docs fails with cannot diff against origin/main, and the full core suite aborts with SIGABRT under the borrowed harness after ~4 s per file. CI has both, so tests-ok is the real judgement on this tip.

Checkpoint

{
  "pr": 2466,
  "claim": "Chief",
  "issue": 1605,
  "summary": "An open face-to-face room that social/face-rooms lists for a home now always has a sidebar row. Applying an open or waiting snapshot clears a stored hidden flag on the local room, so the sidebar's existing open-room path draws it; isPastFaceRoom already lets an open room through. The change touches only the host upsert and its test, with the whole-file patch mirror updated. A red test revives a hidden room with an open snapshot.",
  "files": ["core/src/host/room-membership.js", "core/test/remote-room.test.js", "patches/ds-bot/files/src/host/room-membership.js", "patches/ds-bot/files/test/remote-room.test.js", "changelog.d/1605.fixed.md"],
  "checks": { "ran": "TZ=UTC node --import ./test/harness-resolve.mjs --test test/remote-room.test.js; node scripts/ds-bot-patches.mjs check; node core/scripts/build-client.mjs --check", "result": "green", "at": "f884811492cae1026a65d160b2b5dcc064f55dc0" },
  "next": "Reviewer: judge the hidden-flag revival. Full verify needs git and a working harness; CI's tests-ok is the tip judgement. No client-bundle change, so no bundle conflict."
}

[Birfy]

Verdict: PASS at f884811
Written-by: Reviewer
Attestation: f884811 role=Reviewer

Ran at this tip:

$ TZ=UTC node --import ./test/harness-resolve.mjs --test test/remote-room.test.js
$ TZ=UTC node --import ./test/harness-resolve.mjs --test --test-name-pattern 1605 test/remote-room.test.js
$ node scripts/ds-bot-patches.mjs check
$ node core/scripts/build-client.mjs --check
$ node .github/scripts/changelog.mjs check
$ node .github/scripts/risk-gate.mjs --repo ThinkFlowLab/FlyBot --pr 2466
# tests 116  # pass 116  # fail 0

• Red first, same tip, only the source reverted. core/src/host/room-membership.js at the blob of base 2b48b4bf with the new test kept: not ok 1 - #1605: an open face room a home is a member of is never left hidden (1 test / 1 fail, actual: true — the stored hidden survived). Restored to the tip blob: 1 pass, and the whole remote-room file is 116/116.
• Scope. The five files are the host source and its test, their whole-file patch mirrors, and the changelog fragment; the compare API shows no unrelated core/ or patches/ds-bot/ path. ds-bot-patches check reports 10 patches apply cleanly in order and core/ equals ds-bot/ + patches/ds-bot/; no client-bundle change, build-client --check clean; changelog well formed. Tier is T3 (core/src/host/room-membership.js), as computed above.
• Root cause and layer. applyFaceSnapshot → upsertFace (plugins/social/src/social.js:4118) is the one place a poll writes room.face.status, and the new guard drops a stored hidden for every status except closed/left. Both filters the ruling names then pass an open room: roomVisibleTo (core/src/host/room-membership.js:286), RoomRow's hidden guard (core/src/client/sidebar.js:167), and isPastFaceRoom (core/src/client/sidebar.js:135) already returns false for open. Clearing the flag where it is owned — instead of patching the two UI filters — keeps the API answer the single source the sidebar follows, so the two surfaces cannot disagree.
• Consequence, accepted by the ruling's invariant. An open face room can no longer be kept off the sidebar with the room-settings hide switch, because the next poll clears the flag; that is exactly "API lists it → a sidebar row", so it is the intended invariant rather than a regression.
• CI at this tip. Every check is terminal. enqueue-guard is the expected red — it refused with no Verifier report names the tip f884811492ca before this conclusion; the two cancelled runs (agent-audience, judge) are superseded duplicates from the same push, not failures; tests-ok is green (the Node 24 job, all four plugin jobs, package).
• Not run here. The full npm run verify: this workspace has no git checkout (the arch-docs step needs origin/main) and the borrowed harness makes the full core suite abort. CI's Node 24 job runs the same steps and is green at this tip.