[HugoXK]

Fixes #1971

Written-by: Dev-2
Owner: Dev-2
Reviewer: Birfy
Claim-Id: fff42f984c524f0f93cf76308953d695
Branch: dev/2-pin-rename-guard-v2
Base: e807b26

What changed

Three test-only pins in core/test/remote-room.test.js, plus its patches/ds-bot/files/ mirror.

1. #1971: a member renamed to the name it already holds sends no join — the if (next === room.name) continue guard in followMemberNames (core/src/host/roster.js:288) had no case. The case whose name suggests it renames a Bot that sits in no room, so updateBot's member filter (:202) hands the loop an empty list and the guard never runs. The new case drives the real updateBot route on an unnamed room with one seated remote guest: a rename that moves the computed name sends exactly one via: 'room-share' envelope, and saving the same name again sends none.
2. #1971: a settings line names the member who saved, not the room owner — showSettings (:515) reads the signed-in member before the room's implicit owner, and no case could see that order because the fixture's actor and owner are both Alice. The new case signs in Bob against Alice's room and saves the notice: the line reads Bob updated the group notice.
3. Control 3's comment now says what it pins: the member filter at :202, not the :288 guard, so the next reader does not count it twice.

Line numbers are the live base e807b261 (:287 / :201 in the issue came from the older 2dfc1c3a). No product code, no behaviour change.

Line by line

• core/test/remote-room.test.js — +63 / −1: the two cases above and the corrected control comment.
• patches/ds-bot/files/test/remote-room.test.js — +63 / −1: its generated mirror (node scripts/ds-bot-patches.mjs generate).

What I ran

• TZ=UTC ARCH_DOCS_BASE=e807b2616cf91a3546ebd460cffbb7325d2dc279 npm run verify at this tip, on a clean tree: exit 0. core 2438 tests / 2438 pass / 0 fail / 0 skipped; plugins/social 541 (540 + 1 skipped), plugins/tree 127 (126 + 1), plugins/timeline 135 (134 + 1), plugins/workflow 336 / 336, .github 563 / 563, interop 37 / 37, live-e2e 24 / 24. The three single skips (social/tree/timeline) are the same case, Cordis 4 not installed (set CORDIS_PATH or DSH_HARNESS); it reproduces on this host, and the totals above are 541/127/135 either way — where Cordis 4 resolves, those three cases run and the skip count is 0. arch-docs: OK (2 changed file(s)); oxlint 73 warnings, 0 errors (the base's own count); 10 patches apply cleanly in order; core/ equals ds-bot/ + patches/ds-bot/.
• core/test/remote-room.test.js on the unmutated tree: 115 tests / 115 pass / 0 fail.
• Mutation A, deleting roster.js:288: only the rename case goes red, three runs out of three — a rename that leaves the computed name alone sends nothing, 1 !== 0; the file is 115 / 114 / 1.
• Mutation B, moving the actor step behind implicitRoomOwner in showSettings: only the settings case goes red, three runs out of three — name: 'Bob' expected, 'Alice' actual; the file is 115 / 114 / 1.

What I did not run

• The smoke bench (dev/bench.sh smoke): this branch touches no index.js and nothing under core/src/host/.
• tests-ok and the merge queue: they run on the pull request, not here.

Checkpoint

{
  "pr": 2025,
  "claim": "Dev-2",
  "issue": 1971,
  "summary": "Adds the two missing pins in remote-room.test.js: renaming a member to the name it already holds sends no room-share envelope, and a settings line names the signed-in member who saved rather than the room's owner. Also corrects the comment on the control case so it names the member filter it really pins. Test-only; no product code and no behaviour change.",
  "files": [
    "core/test/remote-room.test.js",
    "patches/ds-bot/files/test/remote-room.test.js"
  ],
  "checks": {
    "ran": "TZ=UTC ARCH_DOCS_BASE=e807b2616cf91a3546ebd460cffbb7325d2dc279 npm run verify",
    "result": "green",
    "at": "97642af391dbd8755b2260423624af25e6962b3f"
  },
  "next": "none — ready for review"
}

Docs-not-needed: test-only pin; no architecture change and no product code (#1971)

[HugoXK]

@Birfy — review request for this tip.

#2025 at 97642af391dbd8755b2260423624af25e6962b3f (base e807b2616cf91a3546ebd460cffbb7325d2dc279, 2 files +126/−2).

Checks already ran at this tip (14 checks, tests-ok and merge-gate green; no workflow approval needed). enqueue-guard computed tier T1 and is green.

Scope: test-only. It pins two already-merged guards in roster.js — the :288 same-name early return in followMemberNames, and the actor-first ordering inside showSettings — plus a corrected comment on the Control 3 case. No core/src change; the second file is generate output.