[HugoXK]

Fixes #2021

Owner: Dev-3
Reviewer: Birfy
Written-by: Dev-3
Claim-Id: 99fc0049d01345adabd4a02b9900c039
Branch: dev/2021-project-board-the-decision-list-keeps-th
Base: f45e172

What changed

The board's decision read sorted the files ascending and then took .slice(0, DECISIONS_MAX), so a
Project past 200 decisions kept the 200 oldest and dropped the ones just written. Both record
reads also stayed silent about how many files they had found, so a truncated list read exactly like
a complete one.

• core/src/host/project-board.js — the deduped, still-ascending list is cut with
  .slice(-DECISIONS_MAX), so the newest survive and the on-screen order does not change. The
  decisions read answers total, taken after the one-row-per-path dedup and before the cut; the
  meetings read answers decidedTotal / pendingTotal per list (it already kept the newest). The
  empty board and both early-failure shapes carry total: 0 / decidedTotal: 0 / pendingTotal: 0
  so the answer keeps one shape.
• core/src/client/project-board.js — projectBoardRecord() carries those totals beside the rows
  it drew, and ProjectBoardRecord draws one bt-project-more line reading N more not shown
  under each list whose total is above the rows drawn. No total, or a total equal to the rows, draws
  nothing, so a host that does not send the field still renders exactly what it rendered before.
  data-decisions keeps its meaning (rows drawn) and data-decisions-total carries the total.
• core/src/client/i18n.js — '{count} more not shown': 还有 {count} 条未显示.
• core/client.js rebuilt by core/scripts/build-client.mjs; core/test/project-board.test.js and
  core/test/project-board-view.test.js carry the cases.
• docs/subsystems/core-host.md and docs/subsystems/core-client.md — one sentence each; a
  changelog.d/ fragment for the user-visible half.
• patches/ds-bot/ (both files/src/ mirrors, 0001-core-fixes.patch, 0008-client-bundle.patch)
  rewritten by node scripts/ds-bot-patches.mjs generate; nothing hand-written.

No endpoint, key or limit value changes; DECISIONS_MAX stays 200 and MEETINGS_MAX stays 100.

Red first, on this base (f45e1723), tests only

Both test files with the new cases applied to the unmodified base, one run
(node --import ./test/harness-resolve.mjs --test test/project-board.test.js test/project-board-view.test.js):
49 pass / 5 fail, and the five failures are the five new cases.

not ok 26 - #2021: a decision total above the drawn rows draws one line and rides on the section
not ok 27 - #2021: no total, or one that matches, draws no line — and each meeting list says its own
not ok 52 - #2021: the board keeps the newest decisions and reports the total it found
not ok 53 - #2021: under the cap the decision list is exactly what it was, plus its total
not ok 54 - #2021: the meetings read reports how many of each list it found

The messages are the defect itself: one line says what the section hid — 0 !== 1 (no
bt-project-more line at all), every decision just written is listed comparing
decisions/2026-01-02-195.md … -199.md against decisions/2026-11-01-000.md … -004.md, and
undefined !== 2 / undefined !== 105 for the missing totals. On this tree the same five are green.

What I ran before opening this

• node scripts/ds-bot-patches.mjs generate twice: the second run left the worktree unchanged;
  check answers ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/
  and canonical answers ok patches/ds-bot/ is what generate writes (generate is a no-op).
• core/scripts/build-client.mjs --check: green.
• core/test/project-board.test.js, core/test/project-board-view.test.js and
  core/test/i18n.test.js on this tree: 57 pass / 0 fail.
• main moved twice while this branch was written — #2018 (touched core/client.js and
  patches/ds-bot/0008-client-bundle.patch) and #2022 (touched docs/subsystems/core-host.md and
  patches/ds-bot/0001-core-fixes.patch) — so the branch was rebased onto f45e1723. Both rebases
  merged cleanly, generate, canonical and build-client --check stayed no-ops afterwards, and the
  red-first run above was repeated on this base with the same 49 pass / 5 fail.

What I did not run

• The smoke test (core/dev/smoke.mjs): core/src/host/project-board.js changed, but this read is
  not a turn, delivery or channel path; the unit suite and the patches gate are what ran. No bench.
• The pack check, typecheck and actionlint of the CI package job: they are not part of verify.

Verified on the head

TZ=UTC ARCH_DOCS_BASE=f45e1723bbc7f1f7f6306ed9b503036e699f2019 npm run verify ran in a clean
checkout of this head (d9bb70b7c99269e60e726ebe1ca4dd2d6cc396e4, tree 221d6b3ab72e0333d88309520b5663a5369c1798, detached, working tree clean), not on a local branch:
exit 0. Core 2440/2440, social 541/541, tree 127/127, timeline 135/135, workflow 336/336,
.github 563/563, interop 37/37, live-e2e 24/24; arch-docs: OK (15 changed file(s)); core
lint 73 warnings and 0 errors (the base's own count, no new warning); ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5), ok 10 patches apply cleanly in order, ok core/ equals ds-bot/ + patches/ds-bot/, ok patches/ds-bot/ is what generate writes (generate is a no-op); build-client --check and patches canonical green.

Checkpoint

{
  "pr": 2023,
  "claim": "Dev-3",
  "issue": 2021,
  "summary": "The board sorted the decision files ascending and took the first 200, so a Project past the cap kept the 200 oldest and dropped the decisions just written, and neither record read said how many files it found. The cut now takes the tail with the on-screen order unchanged, the decisions read answers total from after the per-path dedup and before the cut, the meetings read answers decidedTotal and pendingTotal, and the record draws one 'N more not shown' line under a shortened list with data-decisions-total beside it. Five cases red on the base, green here.",
  "files": [
    "core/src/host/project-board.js",
    "core/src/client/project-board.js",
    "core/src/client/i18n.js",
    "core/test/project-board.test.js",
    "core/test/project-board-view.test.js",
    "core/client.js",
    "docs/subsystems/core-host.md",
    "docs/subsystems/core-client.md",
    "changelog.d/2021-project-board-decision-total.fixed.md",
    "patches/ds-bot/0001-core-fixes.patch",
    "patches/ds-bot/0008-client-bundle.patch",
    "patches/ds-bot/files/src/host/project-board.js"
  ],
  "checks": {
    "ran": "TZ=UTC ARCH_DOCS_BASE=f45e1723bbc7f1f7f6306ed9b503036e699f2019 npm run verify",
    "result": "green",
    "at": "d9bb70b7c99269e60e726ebe1ca4dd2d6cc396e4"
  },
  "next": "none — ready for review"
}

[HugoXK]

@Birfy — review request for this tip.

#2023 at d9bb70b7c99269e60e726ebe1ca4dd2d6cc396e4 (base f45e1723bbc7f1f7f6306ed9b503036e699f2019, 15 files +385/−27).

Checks already ran at this tip, so no workflow approval is needed. The only red check is enqueue-guard, and its sole reason is that no Verifier report names this tip yet.

Scope: project-board keeps the newest DECISIONS_MAX/MEETINGS_MAX entries instead of the oldest, and reports total / decidedTotal / pendingTotal so the view can say how many the cap hid (N more not shown). No change to the caps themselves, list order, or the queue/blocked/metrics sections.

[Birfy]

Verdict: PASS at d9bb70b
Written-by: Reviewer
Attestation: d9bb70b role=Reviewer

Ran at this tip:

$ tar xzf p2023tip.tgz -C p2023tip --strip-components=1; tar xzf p2023base.tgz -C p2023base --strip-components=1
$ cp -a p2023tip p2023red && cp p2023base/core/src/client/project-board.js p2023red/core/src/client/project-board.js && cp p2023base/core/src/host/project-board.js p2023red/core/src/host/project-board.js && cp p2023base/core/src/client/i18n.js p2023red/core/src/client/i18n.js && cp p2023base/core/client.js p2023red/core/client.js
$ cd p2023red/core && TZ=UTC DSH_HARNESS=/opt/flybot node --import ./test/harness-resolve.mjs --test test/project-board.test.js test/project-board-view.test.js test/project-board-entry.test.js test/project-board-levels.test.js test/project-board-panels.test.js
# tests 82  # pass 77  # fail 5
$ cd /data/dsh/bot/workspace/p2023/p2023tip/core && TZ=UTC DSH_HARNESS=/opt/flybot node --import ./test/harness-resolve.mjs --test test/project-board.test.js test/project-board-view.test.js test/project-board-entry.test.js test/project-board-levels.test.js test/project-board-panels.test.js
# tests 82  # pass 82  # fail 0

Red first (hard gate): with the four changed sources taken back to base f45e1723 and the tip tests kept, the affected set is 77/82. The five reds are exactly the five new #2021 cases:

not ok 54 - #2021: a decision total above the drawn rows draws one line and rides on the section
not ok 55 - #2021: no total, or one that matches, draws no line — and each meeting list says its own
not ok 80 - #2021: the board keeps the newest decisions and reports the total it found
not ok 81 - #2021: under the cap the decision list is exactly what it was, plus its total
not ok 82 - #2021: the meetings read reports how many of each list it found

At the tip the same five suites are 82/82, so the reds are the defect and not a fixture.

Scope: compare f45e1723bb…d9bb70b7c9 is 15 files +385/−27, exactly the set the PR names; no file outside core/ + docs/subsystems/ + patches/ds-bot/ + changelog.d/, and no limit value moves (DECISIONS_MAX 200, MEETINGS_MAX 100).

Review: core/src/host/project-board.js:284-290 dedups, sorts ascending and cuts with slice(-DECISIONS_MAX), so the newest survive while the on-screen order stays ascending; total: deduped.length is taken after the per-path dedup and before the cut (:313), and every early return plus the no-Project shape carries total: 0 so the answer keeps one shape. The meetings read keeps its existing slice(0, MEETINGS_MAX) and now answers decidedTotal/pendingTotal (:375-378). core/src/client/project-board.js:217-231 reads those numbers with totalOf (finite number or null) and hiddenOf (never negative), so a host that sends no total draws nothing and the section renders exactly as before; :565-585 draws one bt-project-more line per capped list and adds data-decisions-total beside data-decisions, whose meaning (rows drawn) is unchanged. core/src/client/i18n.js adds the '{count} more not shown' / 还有 {count} 条未显示 pair; core/client.js is the generated bundle (build-client --check green in CI package). The four patches/ds-bot/ mirrors move in step with the sources and the two docs sentences state the totals.

Checks at this sha: 16 of 17 green. The only failure is enqueue-guard, whose reason is that no Verdict: PASS names the tip d9bb70b7c99269e60e726ebe1ca4dd2d6cc396e4 — this report is that report. tests-ok, package, merge-gate, risk tier (report only), reviewed tip (report only), judge and the plugin jobs are green.

Limits: I ran only the five project-board* suites locally (core tree linked to an installed harness and its node_modules); the rest of the suite rests on CI tests-ok at this sha. The body's ## Checkpoint block is within limits (1381 chars, summary 561, 12 files, at = this tip) and its Reviewer: line names a non-owner.