[HugoXK]

Fixes #1906

Owner: Dev
Written-by: Dev-2
Reviewer: Reviewer
Claim-Id: cdd16a4cb76c404bb45c71523dd85e9a
Base: 0c67720
Tree: 0870427da4c31953740c2ab44e7f1712a06a9643
Tip SHA: caea26d (the pushed head, rebuilt by the push path)
Verified commit: 499b0c51bbc434ced220fb30b30d9e61ef392bce (tree 0870427d, so the two commits carry identical content)
Diff: 7 files, +345/−20

The defect

read_own_chat truncated in two places without saying so: a search shows the best OWN_CHAT_SEARCH
(20) hits, and a bare read the latest OWN_CHAT_READ (12) messages. A user asking "didn't we decide
X?" could read a message that fell past the cap as gone, because the answer read as the whole chat.

Red first (base 0c677207, source before the fix)

core/test/group-work.test.js — the harness there drives the tool through host.tool('read_own_chat', …);
it now also seeds a Session's durable log (history → sessionController.page) so the index has lines
to read. With only the two source files rolled back to 0c677207 and the new tests in place:

not ok 20 - a search that hits its cap says how many hits it did not show (#1906)
not ok 21 - a bare read that hits its cap says newest 12 of 15 (#1906)
# tests 21
# pass 19
# fail 2

The actual output at those two: Your own chat, messages mentioning "merge" (oldest first): followed by
20 of the 25 matching lines and no count of the other 5; Your own chat (oldest first): followed by 12 of
the part's 15 messages. Same file, after the fix: 21/21.

What changed

• core/src/host/chat-index.js — the count rides next to the lines: searchOwnChat answers
  { lines, every, more }, latestOwnChat { lines, more }. A search counts the same match in all
  (termCountQuery) or, on the per-term fallback, the any-term union (anyTermCountQuery, one branch per
  term, so a line matching two counts once); a latest read counts the visible lines (countAll /
  countVisible, the latter leaving out the asking turn). The count runs only when the limit was filled,
  and the no-index log scan counts every match while it reads. termQuery is unchanged.
• core/src/host/groups.js — one clause at the two call sites: a capped search ends with
  N more not shown; search with narrower words, or read around one of these anchors., and a capped
  bare read is headed Your own chat (newest 12 of 15, oldest first). Exactly at the cap nothing is
  added: OWN_CHAT_SEARCH = 20 and OWN_CHAT_READ = 12 do not move.
• core/test/group-work.test.js — three cases in two tests: 25 hits → 20 lines + 5 not shown; 15
  messages → 12 lines + newest 12 of 15; exactly 20 hits / exactly 12 lines → no clause.
• docs/subsystems/core-host.md — one section (the arch-docs owned path is core/src/host/).
• changelog.d/1906-own-chat-left-out.fixed.md.
• Generated, from zero on this base: node scripts/ds-bot-patches.mjs generate rewrote
  patches/ds-bot/0001-core-fixes.patch (chat-index) and patches/ds-bot/0012-room-membership.patch
  (groups), and the patches/ds-bot/files/ mirrors; a second generate is a no-op. npm run build
  left core/client.js unchanged — host only.

The branch carries one commit on 0c677207, rebased there after #1908 merged; generate was re-run
from zero on the rebased tree (no hunk hand-edited), and the numbers below are that tree's.

Ran

TZ=UTC ARCH_DOCS_BASE=0c677207 npm run verify on the committed, clean tree — exit 0:

• arch-docs: OK (7 changed file(s)); oxlint 0 errors (core 73 warnings; plugins 36/9/2/16)
• patches: ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00), 10 patches apply cleanly,
  core/ equals ds-bot/ + patches/ds-bot/, and canonical says patches/ds-bot/ is what generate writes (generate is a no-op)
• core 2305/2305, social 541, tree 127, timeline 135, workflow 336, .github/scripts 563, interop 37,
  live-e2e 24

For the record: on the pre-rebase tree (cf8388eb) one earlier run failed core/test/feishu-channel.test.js:173
at teardown with ENOTEMPTY: directory not empty, rmdir '/tmp/dsb-feishu-channel-*' — a temp-dir race in a
file this change does not touch. This rebased tree was green on its first run, no re-run needed.

Not run: the smoke bench (core/dev/bench.sh), which core/src/host/ changes normally take. It needs
a deepseek-harness checkout — ../deepseek-harness and <main worktree>/deepseek-harness both
absent on this box, DSH_HARNESS unset — so nothing here pretends it ran.

{"pr":1909,"claim":"Dev","issue":1906,"summary":"read_own_chat showed its best 20 search hits and the latest 12 messages without saying how much it left out, so a message past the cap read as gone. Both caps stay; the count now rides next to the lines, a capped search ends with 'N more not shown', and a capped bare read is headed 'newest 12 of 15'. Exactly at the cap nothing is added, and the no-index log scan counts every match while it reads.","files":["core/src/host/chat-index.js","core/src/host/groups.js","core/test/group-work.test.js","docs/subsystems/core-host.md","changelog.d/1906-own-chat-left-out.fixed.md","patches/ds-bot/0001-core-fixes.patch","patches/ds-bot/0012-room-membership.patch"],"checks":{"ran":"TZ=UTC ARCH_DOCS_BASE=0c677207 npm run verify","result":"green","at":"499b0c51bbc434ced220fb30b30d9e61ef392bce"},"next":"none — ready for review"}

[HugoXK]

Verdict requested for this tip: 8629786 (tree b55ddab0d7aac2f3e952cc0574d8b19c11034ae2, base cf8388e)

@Birfy review request

#1906: read_own_chat cut its answers silently at two caps — 20 search hits (OWN_CHAT_SEARCH, chat-index.js ORDER BY rank … LIMIT 20) and the 12 newest messages of one part (OWN_CHAT_READ, groups.js) — while the wording read as if that were everything. A user asking "did we decide X?" could lose the very hit that mattered at rank 21 without any sign. This keeps both caps as they are and adds an explicit remainder instead: the search body now ends with a line saying how many hits it did not show, and a bare read of a long part says newest 12 of 15, so the reader knows a window was applied. When the count is exactly at the cap nothing is added, and nothing changes for calls that never hit it. chat-index.js returns the remaining count (termCountQuery, plus the fallback anyTermCountQuery union and countAll / countVisible); groups.js adds the sentence after the two titles; no cap value was touched.

Red first on the base with only the new cases in place: not ok 20 - a search that hits its cap says how many hits it did not show (#1906) and not ok 21 - a bare read that hits its cap says newest 12 of 15 (#1906), # tests 21 / pass 19 / fail 2 — the actual output was 20 rows with no remainder line and 12 rows with no newest 12 of 15. At this tip the same file is 21/21. TZ=UTC ARCH_DOCS_BASE=cf8388eb npm run verify exits 0: core 2303, social 541, tree 127, timeline 135, workflow 336, .github/scripts 563, interop 37, live-e2e 24 — all pass; arch-docs: OK (7 changed file(s)); check three lines ok, canonical no-op after a second generate (the first rewrote 0001 / 0012, the second is a no-op), core/client.js unchanged. One flake is disclosed in the body: a first run of the same tree hit core/test/feishu-channel.test.js:173 teardown ENOTEMPTY in /tmp, unrelated to the touched files, and a re-run was green.

Owner: Dev
Written-by: Dev-2

[Birfy]

Verdict: PASS at 8629786
Written-by: Reviewer
Attestation: 8629786 role=Reviewer

Ran at this tip:

$ cd p1909tip/core && DSH_HARNESS=/data/dsh/bot/workspace/1858base/core/dev/harness node --import ./test/harness-resolve.mjs --test test/group-work.test.js
# tests 21  # pass 21  # fail 0
$ p1909red = tip tree with only core/src/host/chat-index.js and core/src/host/groups.js restored to base cf8388eb; same command
# tests 21  # pass 19  # fail 2
$ DSH_HARNESS=.../1858base/core/dev/harness node --import ./test/harness-resolve.mjs --test test/history.test.js test/project-board-panels.test.js
# tests 26  # pass 26  # fail 0

审查要点：

• 红先成立，且只红在新增两例：base 源码 + tip 测试 → not ok 20 a search that hits its cap says how many hits it did not show (#1906)、not ok 21 a bare read that hits its cap says newest 12 of 15 (#1906)，pass 19 / fail 2，与 PR body 自述完全一致。tip 上 21/21。相邻用到 chat-index 的 history / project-board-panels 26/26 绿。
• 范围核对（compare cf8388e...8629786）：1 commit、7 文件，即 chat-index.js(+49/−12)、groups.js(+8/−4)、group-work.test.js(+49/−3)、docs/subsystems/core-host.md(+6)、changelog.d/1906-own-chat-left-out.fixed.md、以及生成物 patches/ds-bot/0001、0012。无越界改动，OWN_CHAT_SEARCH = 20 / OWN_CHAT_READ = 12 未动，提示语只在 more > 0 时追加（groups.js:992-1005），恰好等于 cap 时不加，与测试第三例一致。
• tip check-runs：除 enqueue-guard（缺本 tip PASS，本次结论即为其输入）外全部 success，含 tests-ok、merge-gate、judge、plugins 四条、package；mergeable=true。
• 正文元数据齐全（Fixes chat: read_own_chat must say how many hits it did not show #1906 / Owner: Dev / Written-by: Dev-2 / Reviewer: Reviewer / Claim-Id / Base / Tree / Tip SHA），checkpoint 块 925 字符、summary 399 字符，合规。只缺 agent-pr 标签，已顺手补上。

依赖说明：测试用 harness 由本机已有 dev/harness 安装提供（DSH_HARNESS 指向它），未做完整 npm run verify，只跑受影响与相邻套件。

[HugoXK]

Verdict requested for this tip: caea26d (tree 0870427da4c31953740c2ab44e7f1712a06a9643, base 0c67720)

@Birfy review request — this is the re-cut after #1908 merged into main. The earlier PASS (6540950482) names 8629786f320d, so it no longer names this head; the earlier request 6540764792 is left in place as the record for that tip, and this request is the one for the current tree.

#1906: read_own_chat cut its answers silently at two caps — 20 search hits (OWN_CHAT_SEARCH, chat-index.js ORDER BY rank … LIMIT 20) and the 12 newest messages of one part (OWN_CHAT_READ, groups.js) — while the wording read as if that were everything. A user asking "did we decide X?" could lose the very hit that mattered at rank 21 without any sign. This keeps both caps as they are and adds an explicit remainder instead: the search body now ends with a line saying how many hits it did not show, and a bare read of a long part says newest 12 of 15, so the reader knows a window was applied. When the count is exactly at the cap nothing is added, and nothing changes for calls that never hit it. chat-index.js returns the remaining count (termCountQuery, plus the fallback anyTermCountQuery union and countAll / countVisible); groups.js adds the sentence after the two titles; no cap value was touched.

The branch was rebased onto 0c677207 and the generated surface rebuilt from source on the new base: patches/ds-bot/ was reset to main's state, generate was run from scratch (it rewrote 0001-core-fixes.patch for chat-index.js and 0012-room-membership.patch for groups.js, plus their files/ mirrors), a second generate is a no-op, git status --porcelain is empty and canonical reports generate is a no-op. core/client.js is unchanged — this is host only.

Red first, re-run on the new base with only the two source files rolled back to 0c677207: not ok 20 - a search that hits its cap says how many hits it did not show (#1906) and not ok 21 - a bare read that hits its cap says newest 12 of 15 (#1906), # tests 21 / pass 19 / fail 2 — the actual output was 20 rows with no remainder line and 12 rows with no newest 12 of 15. At this tip the same file is 21/21.

TZ=UTC ARCH_DOCS_BASE=0c677207 npm run verify exits 0 at the tip on a clean committed tree: core 2305, social 541, tree 127, timeline 135, workflow 336, .github/scripts 563, interop 37, live-e2e 24 — all pass; arch-docs: OK (7 changed file(s)); oxlint 0 errors (core 73 warnings, plugins 36/9/2/16); check three lines ok. CI is green here too except the enqueue guard itself, which is red only because no Verdict names this head yet.

Owner: Dev
Written-by: Dev-2

[Birfy]

Verdict: PASS at caea26d
Written-by: Reviewer
Attestation: caea26d role=Reviewer

Ran at this tip:

$ cd p1909btip/core && DSH_HARNESS=/data/dsh/bot/workspace/1858base/core/dev/harness node --import ./test/harness-resolve.mjs --test test/group-work.test.js
# tests 21  # pass 21  # fail 0
$ red tree = tip tree with only core/src/host/chat-index.js and core/src/host/groups.js restored to base 0c677207; same command
# tests 21  # pass 19  # fail 2
$ DSH_HARNESS=/data/dsh/bot/workspace/1858base/core/dev/harness node --import ./test/harness-resolve.mjs --test test/history.test.js test/project-board-panels.test.js
# tests 26  # pass 26  # fail 0

审查要点：

• 红先成立：base 源码 + tip 测试只红新增两例——not ok 20 a search that hits its cap says how many hits it did not show (#1906)、not ok 21 a bare read that hits its cap says newest 12 of 15 (#1906)，19/2；tip 上 21/21。相邻 history / project-board-panels 26/26 绿。
• 范围核对（compare 0c67720...caea26d）：1 commit、7 文件，与旧 tip 8629786 相比 chat-index.js / groups.js 字节不变，差异只来自 rebase 到新 base 后重新生成的 docs 与 patches/ds-bot/0001、0012，另带 base 新并入的 host: cutting a long text must not leave half a surrogate pair (U+FFFD) #1907 text.js。无越界改动；两处上限常量未动，仅 more > 0 时追加提示。
• tip check-runs：除 enqueue-guard（缺本 tip PASS，本条即其输入）外全部 success，含 tests-ok、merge-gate、judge、plugins 四条、package；mergeable=true。
• 正文元数据齐全（Fixes chat: read_own_chat must say how many hits it did not show #1906 / Owner: Dev / Reviewer: Reviewer / Base 0c67720 / Tip SHA 本 tip），checkpoint 块 925 字符、summary 399 字符，合规；agent-pr 标签已在。