Repository navigation
Add the Project board's seven metrics behind a five-minute cache - #1835
Conversation
The board had counts but no numbers: today's opened and merged PRs and issues, and the seven-day medians of PR merge, issue close and task completion durations, read from GitHub REST beside the local task store. The natural day is the reader's time zone, not the host clock, and a missing credential or a failed read answers `ok: false` with null values so the board paints `—` instead of inventing a zero. The read rides on `project-board`, so the header and the rows cannot disagree, and one five-minute in-process cache spends the source once per window; a failed read is not cached. `runningOf` projects a claimed card into the running table row: who, claim age, source and last activity. Fixes #1829 Docs: docs/subsystems/core-host.md
|
Written-by: Chief 在这个 tip
改完 |
|
Verdict: REQUEST_CHANGES at 073e6f1 Ran at this tip: Red-first: with What blocks this tip
The host module's own nine tests are good, but they inject |
The client half of #1829: the seven cards with their captions, the dash for a value the host could not read, the running table (title, status, holder, claim age, source, last activity) with an overdue mark and a click through the existing onOpen, and one empty line when nothing is running. metricsView is pure so the view tests read it without a fetch. The Waiting/In flight/Blocked groups keep their reason lines beside the one-line count header. Fixes #1829 Docs: docs/subsystems/core-client.md
The seven card labels, their captions, the running table columns and the unavailable line read in zh as well as en; two keys that already existed are not duplicated, and client.js is rebuilt so the bundle carries the new dictionary. Fixes #1829
|
Written-by: Chief 新 tip 这一步是把文件改名（ |
|
Verdict: REQUEST_CHANGES at caa61c3 Ran at this tip: Red-first: with the four changed sources reset to base What blocks this tip
The client half now lands: seven captioned cards, the dash on an unavailable read, the running row with its fields/overdue/click, the i18n keys, the rebuilt bundle and the three view cases are present and green. Risk tier at this tip is |
github-actions
Bot
added
the
risk:T3
|
Written-by: Triage Updated #1835 at
This tip is past the Reviewer's INC at CI at the new tip is in flight. |
|
Written-by: Chief
|
The seven numbers could never render: `project-board` read `rt.githubToken`
and `rt.timeZone`, which no module assigns, so every read answered
`no-credentials` and the day counts fell back to UTC. The token now comes
from the host secret store (`rt.secretValue('GITHUB_TOKEN')`, the path
`connectors.js` reads) and the zone from the request body, which the client
fills with its own zone.
The cache kept the running rows beside the numbers, so a card claimed a
minute ago stayed out of the running table for up to five minutes; the cache
now holds the seven numbers only and the rows are projected from the live
tasks on every read.
The endpoint returned no `metrics` section at all, so the cards had nothing
to draw; `store.js` carries it beside the rows. The subsystem page names the
endpoint the numbers actually ride on. The patch series is regenerated with
the repository's own tooling (git present), so 0008 is hunks again instead of
one whole-bundle replacement.
Ran: TZ=UTC node --test test/project-metrics.test.js test/project-board.test.js
test/project-board-view.test.js -> 47/47; red-first with the four sources
reverted -> 2 failures (the two new cases). node scripts/ds-bot-patches.mjs
generate + check ok; node scripts/build-client.mjs --check ok.
Not run: full `npm run verify` (lint/plugin suites), smoke.
|
Written-by: Rework Reworked onto Ran at this tip's tree (local commit 85ee213b, same tree 7f987ecb): Red-first: with the four changed sources reverted (patch, store, metrics, client board) and the tests kept, Not run here: full What the five INC items now look like:
A fresh PASS at b07e137 is still needed (T3): the INC at caa61c3 named caa61c3. |
|
Verdict: PASS at b07e137 Ran at this tip: Red-first: with INC 剩余项 — 全部关闭
CI at this tip: |
Fixes ThinkFlowLab#1813 Owner: Dev2 Written-by: Dev-2 Reviewer: Birfy Claim-Id: 4bb5d8a6714e4c62b36b4354f6e82051 Base: f7ce89c Tip SHA: 1a56091 Tree: 384ec38 Diff: 7 files, +58/−3 Replayed-by: Replay — merged main f7ce89c into this branch by hand (`update-branch` answered 422 "merge conflict between base and head"), regenerated from the merged core; the change set is the one above, nothing moved. ## What changed The Project board's queue rows beside the columns print a live claim's state through the host's own lowercase lease id — `core/src/client/project-board.js:178` puts `running` or `stalled` in the row and `:252` renders it with `t(row.state)` — but the zh dictionary had `Running` (capital, used elsewhere) and lowercase `done` only, and `t()` returns a missing key unchanged. A Chinese interface therefore read "Dev4 · running". Two entries next to `done` in `core/src/client/i18n.js` close that: ```js running: '运行中', stalled: '已停滞', ``` `运行中` reuses the wording of the existing capital `Running` entry instead of inventing a second translation; `已停滞` matches the stalled card's own copy. The ids the board emits are untouched — only the zh map gains keys, so an untranslated locale still reads `running`. `core/test/i18n.test.js` gains one case that binds a zh dictionary, asserts both lookups, unbinds, and asserts the English fallback. ThinkFlowLab#1768's three cases never bound a dictionary, so the missing-key path (raw id, English by construction) kept CI green over the gap. The branch is based on `b4e05acf` (`ThinkFlowLab#1835`, which re-cut `0001`/`0002`/`0003`/`0005`/`0008` and rewrote `core/client.js`), so this tip is the change re-applied and regenerated on that base, not an earlier tip rebased as text. The force-push to this branch is a lease on the previous tip `be9be42ab9298d223df6166252ded85160f67a17`. ## Red first The new case alone, on base `b4e05acf`, dictionary entries removed, everything else at this tip: ``` ok 1 - every literal the client translates has a Chinese entry ok 2 - copy follows the DSH language and stays English without a locale service not ok 3 - \ThinkFlowLab#1813: the Project board queue states read in Chinese ... 'running' !== '运行中' # tests 3 # pass 2 # fail 1 ``` ## Generated mirrors `core/src/client/` changed, so `node core/scripts/build-client.mjs` rebuilt `core/client.js` (+4) and `node scripts/ds-bot-patches.mjs generate` re-cut `patches/ds-bot/0001-core-fixes.patch` (27/1: the two dictionary lines plus the test, against `ThinkFlowLab#1835`'s new context) and `patches/ds-bot/0008-client-bundle.patch` (5/1) and registered `test/i18n.test.js` under `0001` in `patches/ds-bot/topics.json` — without that entry `generate` refuses with "edited upstream files with no topic". `changelog.d/1813-board-state-i18n.fixed.md` is the one-line fragment. A second `generate` produced byte-identical files for both patches (sha1 verified before and after), and the patch chain reports `core/ equals ds-bot/ + patches/ds-bot/`, so the applied bundle is byte-identical. Nothing in the generated files was edited by hand. The `generate` that ran here rewrote `0002`/`0003`/`0005` too, but byte-identically — the diff carries only `0001` and `0008`, so no face this change does not touch moves. Docs-not-needed: two zh entries and one test; `docs/subsystems/core-client.md` owns `core/src/client/` and still describes the dictionary and its fallback correctly. ## Verification at the tip `Ran:` at `f0f3744b3fea565960b9a9e44f9529a5e167c0a0` (tree `182e73c9`) on the committed tree, `git status --porcelain` empty before and after: ``` $ TZ=UTC ARCH_DOCS_BASE=b4e05acf9c2785eced88e94f1b70e4f15c860c9f npm run verify $ node scripts/ds-bot-patches.mjs check # twice, a generate between them $ node core/scripts/build-client.mjs --check ``` - core: **2218/2218**, including `test/i18n.test.js` 3/3 - plugins social 541/541, tree 127/127, timeline 135/135, workflow 294/294 - `.github/scripts` 549/549, interop 37/37, live-e2e 24/24 - oxlint: 0 errors (71 warnings) in core; plugin lints 0 errors (36/9/2/16 warnings) - `build-client.mjs --check`: clean - `arch-docs: OK (7 changed file(s))` with `ARCH_DOCS_BASE=b4e05acf9c2785eced88e94f1b70e4f15c860c9f`, read off the committed tree's run - patch chain: ``` ok ds-bot/ = Fei2411/DeepSeek-Bot@2b10c70 (tree 5834c00, v0.1.5) ok 10 patches apply cleanly in order ok core/ equals ds-bot/ + patches/ds-bot/ ``` `Not run:` the smoke bench (no change to `index.js` or `src/host/`), the CI `package` job (pack check, typecheck, actionlint) and the merge-queue rebuild — those run in CI and on the queue entry, not locally. ## Checkpoint <!-- flybot:checkpoint --> ```json { "pr": 1830, "claim": "Dev2", "issue": 1813, "summary": "The Project board's queue rows print the host's lowercase lease ids (running, stalled) through t(), which returned them unchanged because the zh map had no such keys. Two entries beside done now read 运行中 and 已停滞, reusing the capital Running wording; emitted ids and fallback stay untouched. A case binds a zh dictionary and asserts both lookups, which ThinkFlowLab#1768 never covered. This tip re-applies it on b4e05ac, where ThinkFlowLab#1835 re-cut the patches and rewrote client.js: bundle rebuilt, chain regenerated, second generate byte-identical, check proves core equals ds-bot plus patches.", "files": [ "core/src/client/i18n.js", "core/test/i18n.test.js", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/topics.json", "changelog.d/1813-board-state-i18n.fixed.md" ], "checks": { "ran": "TZ=UTC ARCH_DOCS_BASE=b4e05acf npm run verify; node scripts/ds-bot-patches.mjs check (twice, generate between); build-client.mjs --check", "result": "green", "at": "f0f3744b3fea565960b9a9e44f9529a5e167c0a0" }, "next": "none — ready for review" } ``` <!-- /flybot:checkpoint --> Co-authored-by: Danyang Chen <birfychen@gmail.com>
Written-by: Dev
Reworked-by: Rework
Fixes #1829
Owner: Dev
Reviewer: Reviewer
Tip SHA: b07e137
Base: f245520
Docs-not-needed: no —
docs/subsystems/core-host.mdanddocs/subsystems/core-client.mdcarry the two sections.What changed
core/src/host/project-metrics.js— the seven numbers (PRs opened/merged today, issues opened/closed today, 7-day medians of PR merge, issue close and task completion), a five-minute in-process cache, andrunningOffor the running table. The token comes from the host secret store (GITHUB_TOKEN) and the day boundary from the request'stimeZone, so a reader in Shanghai gets its own day. A missing credential or a failed read answersok: falsewithnullvalues, and a failed read is never cached.project-boardcarriesmetricsbeside the rows (the endpoint returns it), so header and rows come from one read. The cache holds the seven numbers only; the running rows are projected from the live tasks on every read.core/src/client/project-board.jsrenders the seven cards (each with its one-line caption), draws—for every value the host could not read, and renders the running table — task, status, who, claim age, source (bot / group / workflow), last activity — with an overdue mark pastRUNNING_OVERDUE_MS, a click through the existingonOpen, and one empty line when nothing is running. It asks the endpoint for the reader's zone.core/client.jsis rebuilt fromsrc/client(npm run build).core/test/project-metrics.test.js(natural-day boundary in two zones, per-field day counts, empty window →—, seven-day window, no-credential and failed-read degradation, cache hit spending the source once, a card claimed after a cached read still running, running-row projection, task median) andcore/test/project-board.test.js(the board readsGITHUB_TOKENfrom the host secret store and the zone from the call) plus three view cases incore/test/project-board-view.test.js.patches/ds-bot/is regenerated with the repository's own tooling on a machine with git, so 0008 is hunks again instead of one whole-bundle replacement, andfiles/mirrors the new sources.Reworked from the INC at caa61c3
changelog.d/1829-project-metrics.added.md— renamed (done at bae6e49).project-board.js—rt.secretValue('GITHUB_TOKEN')replaces the unassignedrt.githubToken; a test asserts the board carries the token.project-board.js— the zone comes from the request body (client sends its own),UTConly as the fallback.project-metrics.js— the cache keeps the seven numbers;runningis derived from the livetasksevery read.patches/ds-bot/0008-client-bundle.patch— regenerated with git: one 14,040-line hunk is now 274 hunks.## Checkpoint— trimmed under 1,500 characters with a summary under 600.docs/subsystems/core-host.md— the numbers ride on theproject-boardendpoint, not aproject-metricsendpoint instore.js.Checkpoint
{ "pr": 1835, "claim": "Dev", "issue": 1829, "summary": "Host: `project-metrics.js` counts today's opened/merged PRs and opened/closed issues in the reader's zone, with seven-day medians of PR merge, issue close and task completion; its token now comes from the host secret store, its zone from the request, and the cache holds the numbers while the running rows are read live. `store.js` returns the `metrics` section beside the rows. Client: seven captioned cards, a dash for an unreadable value, and the running table with the overdue mark and the row click. Tests cover the day boundary, degradation, the cache, the live rows and the token/zone wiring.", "files": [ "core/src/host/project-metrics.js", "core/src/host/project-board.js", "core/src/host/store.js", "core/src/client/project-board.js", "core/client.js", "core/test/project-metrics.test.js", "core/test/project-board.test.js", "docs/subsystems/core-host.md" ], "checks": { "ran": "TZ=UTC node --test test/project-metrics.test.js test/project-board.test.js test/project-board-view.test.js (47/47); node scripts/ds-bot-patches.mjs check; node scripts/build-client.mjs --check", "result": "green", "at": "85ee213b6c643a2930c09c3304fd673da90bc092" }, "next": "CI tests-ok at this tip is the gate, then a fresh PASS; full npm run verify (lint and the plugin suites) and smoke are unrun here." }