Repository navigation
Settings canvas draws a skipped workflow node as Queued, while the Room calls it Skipped - #1805
Merged
Merged
Conversation
…ThinkFlowLab#1789) `statusLabel()` knew running/done/failed/idle and fell back to "Queued" for everything else, so an untaken branch of a live run was drawn as if it were still waiting, while the Room's Flow panel names that same node "Skipped". The engine does write `skipped` (`plugins/workflow/src/graph.js` STATUSES and the untaken-edge close), and the Room maps it already; this canvas now does too, in both languages. Docs-not-needed: docs/subsystems/core-client.md describes the Settings flowchart's wire plane, fit and edit mode, not the per-node status chip vocabulary; this changes one label mapping and one zh key, no architecture. Fixes ThinkFlowLab#1789
Contributor
Author
|
T1 at this tip: enqueue request for
State at this head: Written-by: FlyBot Lead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1789
What changed
Settings → Workflows drew every node whose status it did not know as Queued.
statusLabel()incore/src/client/workflows.jsmatchedrunning,done,failedandidleand fell through toQueued, so a branch the run never took — which the engine writes asskipped(plugins/workflow/src/graph.jsSTATUSES, and the untaken edge's close) — was drawn as if it were still waiting, while the Room's Flow panel names that same node Skipped.One mapping is added (
skipped → t('Skipped')) and the zh dictionary gains the key (Skipped: '跳过') — the word the Room already uses (plugins/workflow/client.js:102), not a new one. Nothing else in the canvas is touched: no geometry, no fit, no edit mode.Red first — live base
Two reds were taken on the base
92a4cf26before this fix existed (the branch carries them; the test file is the only addition in red 1).Red 1 — test only, source untouched (
'Queued'is what the chip says today):Red 2 — with
statusLabel()fixed but no zh key, the same test fails on the Chinese half:The test asserts both languages (
Skippedand跳过);core/test/i18n.test.jsstays green.Real line counts (additions + deletions vs base; generated artifacts separate)
core/src/client/workflows.js: +1 = 1core/src/client/i18n.js: +1 = 1core/test/workflows-page.test.js: +29 = 29changelog.d/1789-workflow-skipped-chip.fixed.md: +1 = 1Generated by
scripts/ds-bot-patches.mjs generateplusnpm run build(not counted above):core/client.js+2 (the built bundle)patches/ds-bot/files/src/client/workflows.js+1,patches/ds-bot/files/test/workflows-page.test.js+29 (verbatim mirrors)patches/ds-bot/0001-core-fixes.patch+42/−43 — inside the patch the real change is +1 line and one hunk count; the rest is hunk-header churnpatches/ds-bot/0008-client-bundle.patch+534/−537 — the re-cut bundle patch; no hunk was hand-editedHow it was generated, exactly:
cd core && npm run build, then the whole chainnode scripts/ds-bot-patches.mjs generate. On this box (git 2.34.1) the plain generator splits the bundle diff differently from the shapemainstores (9.2k changed lines in0008alone), whilegit diff --minimalreproduces that shape (381 hunks, as inmain); so generation ran with agitshim that inserts--minimalinto plaingit diffcalls. Afterwards the patches this change does not carry (0002,0003,0005,0007,0009,0012,0014,0016) were restored tomain's bytes, as agreed — they would otherwise carry only header noise. No hunk of the two carrier patches was edited by hand.Verification at the tip
3a331c5519ded77499be15cd76d5e48f722924c3f59649851a31c0a410a7a8b4dc77fd5281de93ce30c049077d52a70db546adcae157694bb366a098(live main when the branch was rebased and verified; the push helper re-checks the base)TZ=UTC ARCH_DOCS_BASE=30c04907 npm run verify→ exit 0.github/scripts/*.test.mjs549/549 · interop 37/37 · live-e2e 24/24 — every suite# fail 0ds-bot-patches check, twice, the same three lines both times:generateat this base reproduced this commit's bytes exactly: after each of the twogenerateruns — with the eight patches this change does not carry restored tomain's bytes —git statuswas empty andgit diff -p HEADwas the empty patch (e3b0c442…)node scripts/build-client.mjs --checkexit 0arch-docs: OK (9 changed file(s))at base30c04907Docs
The commit and this body carry
Docs-not-needed::docs/subsystems/core-client.mddescribes the Settings flowchart's wire plane, fit and edit mode, not the per-node status chip vocabulary; this adds one label mapping and one zh key.Gates at this head
The guard at this tip (
PATHshimgh,GH_REPO=ThinkFlowLab/FlyBot node .github/scripts/enqueue-guard.mjs --pr 1805):(the guard never enqueues; queueing stays with the Lead)
Checkpoint
{ "pr": 1789, "claim": "Dev-1", "issue": 1789, "summary": "Settings to Workflows drew a node the run skipped as Queued: statusLabel matched running/done/failed/idle and fell through to Queued, so an untaken branch of a settled run read as still waiting while the Room names that node Skipped. One mapping added (skipped to t('Skipped')) plus the zh key Skipped: '跳过', the word the Room already uses; the test asserts both languages. No geometry, fit or edit-mode change.", "files": ["core/src/client/workflows.js", "core/src/client/i18n.js", "core/test/workflows-page.test.js", "changelog.d/1789-workflow-skipped-chip.fixed.md"], "checks": { "ran": "TZ=UTC npm run verify; ds-bot-patches check twice; whole-chain generate twice; build-client --check", "result": "green", "at": "3a331c5519ded77499be15cd76d5e48f722924c3" }, "next": "Ready for review at this tip; needs a Verifier report naming this head." }