Repository navigation
fix(social): Past rooms Open works on every home; one face-room title for all members (#171, #172) - #175
Conversation
Past rooms on a peer home could not be opened after the room left Bot Social because the local hosted room was dropped and Open only passed a dead session id. Keep the hosted transcript when a room falls off the server list, add social/face-open to resolve or recreate the session, and route Past Open through it. Face-to-face titles now list every participant owner in stable handle order and refresh auto titles when the roster grows, on the server and in the Friends panel. Co-authored-by: Danyang Chen <birfychen@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4087048cb0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rememberPastFace(viewHostedFace(hosted, { faceRoomId: serverId, localRoomId: meta?.localRoomId, status: 'closed' }) | ||
| || { faceRoomId: serverId, roomId: meta?.localRoomId, name: faceRoomTitle({}, { code: meta?.joinCode, room: hosted }), status: 'closed', members: [] }) | ||
| if (meta?.localRoomId) await flybot.rooms.dropFace?.(meta.localRoomId).catch(() => {}) | ||
| delete settings.faceRooms[serverId] |
There was a problem hiding this comment.
When faceApi.list() stops returning a room that was already open, this branch now keeps the hosted room but only marks the copied past snapshot as closed; the persisted room.face.status remains open. core/src/client/sidebar.js:isPastFaceRoom therefore continues to show the room as live while social/face-rooms also emits it under Past rooms, and the stale live state remains after this metadata is deleted. Update the hosted room to closed here while retaining its history.
Useful? React with 👍 / 👎.
| || Object.entries(settings.faceRooms).find(([, meta]) => meta.localRoomId === roomId)?.[0] | ||
| if (!serverId) throw new Error('which room?') | ||
| const seed = past || { faceRoomId: serverId, roomId, status: 'closed', members: [] } | ||
| const room = await flybot.rooms.upsertFace?.({ |
There was a problem hiding this comment.
When this fallback is actually needed because an explicit Leave or older cleanup removed the hosted room, rememberPastFace has retained only summary fields, and this upsertFace call passes neither the original local session id nor any history. Core consequently creates a new session whose room log is empty, so Open lands on a blank conversation rather than the past transcript. Keep the original hosted room on those transitions or retain and reopen its history instead of creating a metadata-only replacement.
Useful? React with 👍 / 👎.
| return { roomId: room.id, faceRoomId: serverId } | ||
| } | ||
| disposers.push(flybot.api.handle('social/face-join', async ({ code, botId } = {}) => joinFaceRoom({ code, botId }))) | ||
| disposers.push(flybot.api.handle('social/face-open', async (payload) => openFaceRoom(payload), { read: true })) |
There was a problem hiding this comment.
When the hosted room is absent, openFaceRoom invokes rooms.upsertFace, which creates a DSH session and saves core state. Declaring this handler { read: true } makes channel.js serve it while another DSH owns the state lock and makes authz.js bypass the deployment-wide plugin-write block for every signed member; the fallback then either errors inside createSession on a read-only host or lets a non-owner mutate shared room state. Split pure resolution from recreation or register recreation as a write.
AGENTS.md reference: AGENTS.md:L60-L60
Useful? React with 👍 / 👎.
| return `${MONTHS[date.getMonth()]} ${date.getDate()} ${hh}:${mm}` | ||
| } | ||
|
|
||
| export function isAutoFaceTitle(name) { |
There was a problem hiding this comment.
This commit changes files owned by both core-host and social, but changes neither docs/subsystems/core-host.md nor docs/subsystems/social.md, and its commit message has no Docs-not-needed: trailer. The repository's architecture-doc gate therefore rejects this tip before the required verification can pass; update the subsystem docs or add a justified trailer.
AGENTS.md reference: AGENTS.md:L94-L94
Useful? React with 👍 / 👎.
| for (const member of members ?? []) { | ||
| const owner = String(member?.ownerName ?? member?.owner_name ?? '').trim() | ||
| const key = owner.toLowerCase() | ||
| if (!owner || seen.has(key)) continue |
There was a problem hiding this comment.
When one home brings multiple Bots, the same owner appears under multiple handles. Because deduplication happens before handle sorting, the retained handle for that owner depends on input order: members A@z, B@m, A@a produce B, A, while reordering them to A@a, B@m, A@z produces A, B. Homes receiving different member-array orders can therefore still show different titles; sort all member rows by handle first and then deduplicate owners.
Useful? React with 👍 / 👎.
Fixes #171
Fixes #172
Summary
social/face-openresolves the hosted room or recreates it from the past snapshot; Past rooms Open and row click use it; no Open button without a room id.formatFaceRoomTitle, auto titles refresh), and the friends panel rebuildsFace-to-face · …from the full member list instead of keeping a stale partial name.Fork PR: Birfy#21
Test plan
ARCH_DOCS_BASE=upstream/main npm run verify(agent run, Node 24)