Repository navigation
Stop preselecting the first Bot in the new-task form - #1671
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Fixes #1334
Owner: Chief
Reviewer: Reviewer
Tip SHA: 2b6aa22
Base: 2349444
Docs-not-needed: no —
docs/subsystems/core-client.md(the page that ownscore/src/client/schedules.js) is updated here.What and why
The Scheduled tasks form opened with
roster.bots[0]?.idalready chosen, so Create task was live on a form nobody had filled in: one click created the task for whichever Bot sorted first in the roster. That is the shape #1322 fixed in the copy picker, left in place there on purpose.Six columns
TaskFormseedstargetwithstart ?? ''(noroster.bots[0]), the Send to select opens on the placeholder "Pick a Bot or group chat", andsubmitreturns whiletarget === ''— so the disabled button and the form's submit path agree. Editing keeps the task's own chat.core/test/schedules-client.test.js: one new case asserts the form opens with''and the placeholder as the first option, Create task disabled, and a submit with no target calling noscheduleCreate; the second half seeds a picked room and checks it is what gets sent.core/src/client/schedules.jsswapped back to the base blob: 22 pass, 1 fail (the new case). At the tip: 23 pass, 0 fail.onChange) — the owner decision says it is not this issue's acceptance. No smoke run:index.jsandsrc/host/are untouched.Ran at the tip
Not run: the full
npm run verifyand the smoke test (no git on this box for the pin hash; CI runs both on this tip).Checkpoint
{ "pr": 1671, "claim": "Chief", "issue": 1334, "summary": "The new-task form no longer opens with the first roster Bot chosen. Its target starts empty, the Send to picker shows the placeholder, and both the Create button and the form's submit path refuse to send until a Bot or group chat is picked. Editing an existing task still opens on that task's own chat. A new client test pins the opening state, the placeholder, and that an unpicked submit calls nothing.", "files": [ "core/src/client/schedules.js", "core/test/schedules-client.test.js", "core/client.js", "patches/ds-bot/0001-core-fixes.patch", "patches/ds-bot/0008-client-bundle.patch", "patches/ds-bot/files/test/schedules-client.test.js", "docs/subsystems/core-client.md", "changelog.d/1334-taskform-no-preselect.fixed.md" ], "checks": { "ran": "node scripts/build-client.mjs && node --import ./test/harness-resolve.mjs --test test/schedules-client.test.js && node scripts/ds-bot-patches.mjs check", "result": "green", "at": "2b6aa22169f7179ce3e469e5eb83512bd424a589" }, "next": "Reviewer: judge the tip; red-first evidence is the base-source run in the body. Then queue (T1 expected, no PASS needed if risk-gate says T1)." }