Repository navigation
fix(chat): busy-ack shows a blinking indicator, not a canned line, until the host ack lands (#1656) - #1657
Merged
Conversation
…til the host ack lands (ThinkFlowLab#1656)
Collaborator
Author
|
Verdict: PASS at ca01a97 Ran at this tip: Review notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1656
Written-by: Dev-1
Owner: Dev
Reviewer: Reviewer
Tip: ca01a97
Tree: d3c03c7070fd790081928a9e6728e5fe85e2e746
What happens
#1630 (merged at 69a9b2b) made the host compose a context-aware busy-ack, but while that ack is still pending (only a local
queued/steeringsubmission) the client drew the fixedBUSY_ACK_KEYsentence 「看到了,这步做完就接着处理你这条。」, so users still saw a canned line first.What it does now
busy-ack-logic.js:BUSY_ACK_KEYis removed;busyAckText(hostAck)returns the host text (trimmed) or'',busyAckPending(hostAck)is true until a host line exists;busyAckVisibletreats a blank host text as no ack.BusyAckBubble: with host text it draws that text in the bubble, unchanged; while pending it draws the Bot's mark plus a three-dot blinking indicator (.bt-busy-dots,aria-busy,data-pending, reduced-motion respected) and no text. The host line replaces it when it lands.docs/subsystems/core-client.mdbusy-ack paragraph updated.Generated artifacts
core/client.jsfromnpm --prefix core run build(build-client.mjs --checkexit 0);patches/ds-bot/0001,0003,0008and thepatches/ds-bot/files/...mirrors fromnode scripts/ds-bot-patches.mjs generate;ds-bot-patches check: 10 patches apply cleanly, core/ equals ds-bot/ + patches. No generated file hand-edited.Tests
core/test/busy-ack-client.test.js(4 tests): placement, visibility incl. blank host text, pending → no text / host text shown, and the canned zh/en sentence absent frombusy-ack.js,busy-ack-logic.js,i18n.jsand the bundleclient.js.node --test test/busy-ack-client.test.js test/busy-ack.test.js test/i18n.test.js(core): 16/16 pass.cd core && npm test: 1924 tests, 1919 pass, 4 fail —at-menu.test.js,#1320 dsh-schedule task type,recurring task missed…,a loaded DSH clock…; the same 4 fail onorigin/mainon this box (environment), none touches busy-ack.No screenshot: there is no local render harness for the core chat bubble on this box.