Repository navigation
fix(workflow): Runs drawer — duration gap before status chip; Failed once - #1619
Merged
Birfy merged 2 commits intoOct 29, 2026
Merged
Conversation
…nkFlowLab#1618) Keep HH:MM in a non-shrinking meta column with a CSS gap before the status chip so Done no longer reads as 02:27Done. Skip wf-hist-reason when it only repeats the Failed chip label.
Avoid wf-hist-status so existing exact className === 'wf-chip running' checks still see hist Running chips; flex-none via the parent selector.
Collaborator
Author
|
Verdict: PASS at ac20811 Ran at this tip: FindingsNo actionable findings. Runs hist keeps HH:MM in non-shrinking meta with gap before status chip; generic Failed skips wf-hist-reason so the chip paints once. Chip class stays Residual
|
This was referenced Oct 29, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner: Danyang Chen
Reviewer: Reviewer
Written-by: Grok Bot (box-local; no Cursor CloudAgent)
Fixes #1618
What changed
Workflow room → Runs tab status column painted badly on LIVE (~
ac7a916b): Done rows jammedHH:MMinto the green Done pill (02:27Done), and some Failed rows double-drew time +wf-hist-reason“Failed” +wf-chip“Failed” (clipped red F). Separate from #1508/#1588 title ellipsis and #1478 badge alignment; does not re-file #1513-class Flow clip.Runskeeps the clock inwf-hist-meta/wf-hist-timeand the status chip as a hist sibling (wf-chip <status>class unchanged); CSS makes taskflex:1, meta/time/.wf-hist>.wf-chipflex:none, histgap:10px(dropsmin-width:0on meta so time cannot overflow into the chip).wf-hist-reasonwhenfailureTextequals the status chip label (generic Failed with no host detail); real step reasons still show.Verification at the tip
Tip SHA:
ac20811d12a02297fc598e9e461ddaeedfb790b6Ran:
cd plugins/workflow && node --import ./test/resolve.mjs --test --test-timeout=15000 test/client.test.js→ 70 pass / 0 failshowReasonfor every failed row + restoremin-width:0on meta → fix(workflow): Runs drawer — duration collides with Done chip; Failed rows double-draw an F #1618 fails (generic Failed must not double-draw); restore tip → passnode .github/scripts/changelog.mjs check→ well formedplugins (workflow)/ubuntu-latest/tests-okgreenNot run: LIVE/prod upgrade (out of scope).
Residual
Checkpoint
{ "pr": 1619, "claim": "Danyang Chen", "issue": 1618, "summary": "Runs drawer keeps HH:MM in a non-shrinking column with a gap before the status chip so Done no longer reads as 02:27Done, and a Failed row without host detail paints the Failed chip once instead of also drawing a clipped wf-hist-reason F.", "files": [ "plugins/workflow/client.js", "plugins/workflow/test/client.test.js", "docs/subsystems/workflow.md", "changelog.d/1618-runs-duration-chip.fixed.md" ], "checks": { "ran": "client.test.js 70/70; #1618 red-first knife; changelog check; CI tests-ok", "result": "green", "at": "ac20811d12a02297fc598e9e461ddaeedfb790b6" }, "next": "enqueued on main merge queue at tip ac20811d — do not force-merge" }