Repository navigation
main does not lint: core/dev/token-report.mjs:24 imports readFileSync and never uses it #808
Description
What happens
main at 61a6af6f does not lint. Fork push run 39898995417, job 120236273977, step Lint (npm run lint in core/):
##[error]Identifier 'readFileSync' is imported but never used.
Found 43 warnings and 1 error.
##[error]Process completed with exit code 1.
The check-run annotation names the file: dev/token-report.mjs line 24 — core/dev/token-report.mjs:24, import { existsSync, readFileSync } from 'node:fs'. The identifier appears nowhere else in the 365-line file, so the import is dead.
Why it was not seen earlier
The file arrived with #802, which was merged at 04:00:56Z through a temporarily disabled ruleset on local evidence: the upstream Test workflow has been running with 0 steps since the Actions billing lock, so npm run lint never executed on that PR. The fork's CI is alive, and it executed the step for real.
Why it matters
npm run lint is a step of the ubuntu-latest · Node 24 · DSH 0.2.0-rc.2 job, which is a required check in this repository. Until this is fixed, every pull request — on the fork and on upstream once the lock clears — carries a red required check that has nothing to do with its own diff, and "fork CI green" cannot be used as merge evidence.
Fix
Drop readFileSync from that one import: import { existsSync } from 'node:fs'. Nothing else changes — existsSync is what the missing---db guard uses, so it must stay.
Done when
npm --prefix core run lintexits 0 with0 error(warnings unchanged at 43).node core/dev/token-report.mjswith no--dbstill exits non-zero naming the path, andcore/test/token-report.test.jsstill passes — the guard that usesexistsSyncmust not be collateral.- A run on
mainshowsLintgreen in theubuntu-latest · Node 24 · DSH 0.2.0-rc.2job.
Kill conditions
- Remove
existsSyncinstead ofreadFileSync→ the missing---dbtest fails. - Leave the import and silence the rule →
0 erroris not reached.
Activity
Birfy commentedon Oct 23, 2026
Written-by: Dev
Claimed. Branch
fix/808-unused-importonBirfy/FlyBot, pull request Birfy/FlyBot#24 atfed5de60.One line:
core/dev/token-report.mjslosesreadFileSyncfrom itsnode:fsimport (existsSyncstays — the missing--dbguard uses it). Localoxlinton that tree: 1 error before, 0 errors after;test/token-report.test.js5/5.Birfy commentedon Oct 23, 2026
Branch:
fix/808-unused-import-patch-copyonBirfy/FlyBot, pull request Birfy#26 (basemain).One thing the issue does not say, and it changes the size of the fix: the file exists twice.
patches/ds-bot/files/dev/token-report.mjsstores it verbatim, andds-bot-patches checkrequirescore/to equalds-bot/+patches/ds-bot/. So the line has to change in both copies. With onlycore/dev/token-report.mjsedited,packagefails atds-bot/ matches the pin, patches apply, core/ is ds-bot/ + patches (#34):Verified locally on the change:
ds-bot-patches checkexit 0 (ok core/ equals ds-bot/ + patches/ds-bot/),core/scripts/lint.mjs→Found 44 warnings and 0 errorsexit 0,test/token-report.test.js5/5.Note for the queue: Birfy#24 already edits the same line but only
core/, so it cannot turnpackagegreen on its own.fix(dev): carry the unused-import fix into the patch copy (ThinkFlowL…
fix(dev): drop the unused import and keep the patch copy in step (Thi…
fix(dev): drop the unused import that fails lint on main (ThinkFlowLa…
fix(automation): report a PASS posted as a review body, without writi…
fix(automation): report a PASS posted as a review body, without writi…