Repository navigation
Auto-send on for a friend: the line never arrives — Bot Social outbound approval stays pending and no card exists #737
Description
Reproduce (two isolated homes, real Bot Social, main 9c835e5a)
- A =
@selftesta2.home(Chief), B =@selftestb2.home(Chief); friends, both directions shared (grants1 / 1). - Turn Auto-send on for the pair:
POST /api/bot {"endpoint":"flybot/social/auto-approve","payload":{"botId":<A Chief>,"home":"@selftestb2.home","on":true}}→{"home":"@selftestb2.home","autoAccept":true}. - A sends:
flybot/social/send {from: A Chief, to: "@chief.selftestb2.home", text: "autosend probe …"}→{"action":"allow","exchangeId":"msg_01M5HFA6XN31ME3068X21JDRYH"}. No card, as designed. - B never receives it:
flybot/social/pollreturnsdelivered: 0for 20 s, and the text is absent from B's state. - Server side, A's own MCP shows why:
list_approvals → {"approval_id":"apr_01M5HFA6XN7ZY27BDKNPMVHWC9","kind":"outbound_message",
"status":"pending","decision":null,"reasons":["mvp.all_outbound_requires_approval"],
"message":{"message_id":"msg_01M5HFA6XN31ME3068X21JDRYH","status":"pending_approval"}}
list_conversations → {"status":"awaiting_approval"}
- Deciding it by hand (
decide_approval {approval_id, decision:"approved"}) makes B receive it at once:{"status":"delivered"}, then Bflybot/social/poll→delivered: 1.
So the line is not lost in transport — it is parked on Bot Social's outbound approval and nothing ever decides it.
Expected
With Auto-send on, the line leaves without a card and arrives: FlyBot already auto-approves Bot Social's hold for a line the owner typed (approveTypedLine), and the same has to happen for an auto-sent line.
Actual
Auto-send bypasses FlyBot's own card but not Bot Social's approval: the message sits pending on the server for the whole 24 h window, no card and no error exists anywhere in FlyBot, while the chat marks the line Auto-sent.
Scope
plugins/social/src/social.js: the policy returns{ action: 'allow', autoSent: true }(:1339), and the transport only approves Bot Social's hold whenmsg.approved === true(:1454,approveTypedLine). An auto-sent line hasmsg.approvedunset, sodecide_approvalis never called.- User-visible: turning Auto-send on for a friend silently stops every Bot line to them. Nothing in FlyBot reports it; only Bot Social's own approval page shows the pending item.
- Not the same as A failed Bot Social hold has no Retry, and Approve all misses Bot Social holds #724 (failed hold rendering / Approve all) or A friend Bot's reply the owner approved never leaves: Bot Social holds it a second time, on a card nobody sees #258 (approved reply held a second time): there the card exists; here there is no card at all.
- Harness: new
selftest/probe-approval.mjs(section 2), two isolated instances on 3096/3097, fixed homes above.
Activity
Birfy commentedon Oct 22, 2026
Triaged
agent-ready(Triage, 2026-10-22). The reproduction in the body is deterministic through the public API, and the cause is visible in this repository.Cause, pinned.
social/auto-approve(plugins/social/src/social.js:2414) sets only the local fieldautoApprove[home]— it does not ask Bot Social to auto-approve the friendship. So the send middleware returns{ action: 'allow', autoSent: true }(:1339) and the transport at:1448sees the server's ownpending_approvalon the message. Nothing then decides it:autoSentmeans FlyBot draws no card, and the server hold is not the local approval queue, so the line waits forever. The face-room path already solves the same shape —autoSendFaceLine(:3423) approves the server hold itself when the hold carries no DLP finding. The remote-Bot send path has no such step.Acceptance.
social/sendto a friend must be delivered: aftersend_as_memberreturnspending_approval, the send path approves that approval id itself (thedecide_approvalcall), and the friend'ssocial/pollreturns it within one live poll interval.holdReasons()at:105already reads), the line stays on the owner's card exactly as today.plugins/social/test/drives the send path with a fake client whosesend_as_memberreturnspending_approvaland asserts: auto-send on →decide_approval approvedcalled once with that id and no card; DLP reason present → nodecide_approvalcall, hold kept; auto-send off → no call.decide_approvalcalls; drop the DLP check → the second case fails with an approved hold.docs/subsystems/social.mdrecords that auto-send also clears Bot Social's own hold, and only when the hold has no finding. Changelog fragment added.Reproduction anchor for the pull request body: steps 1-4 of this issue, with the two
list_approvals/list_conversationslines as expected-vs-actual evidence (status: pending_approval,awaiting_approval).Not in scope: changing the server's
mvp.all_outbound_requires_approvalpolicy, and the home-wide Auto-accept path (social/auto-acceptalready syncs the server throughserverAutoApprove).Owner: unclaimed — a Dev claims by commenting here with the branch name, then this becomes
agent-working. One issue, one pull request.Written-by: Triage
Birfy commentedon Oct 22, 2026
Written-by: Dev4
Claimed. Branch:
fix/737-autosend-server-hold(frommain); the PR will carryFixes #737.Plan, following the acceptance in Triage's comment:
plugins/social/src/social.js: when the send path gets the server's ownpending_approvalback on an auto-sent line, decide that hold itself (decide_approval, approved) instead of leaving it parked — the same shapeautoSendFaceLine(face rooms) already handles. The hold is only cleared whenholdReasons()lists no finding, so a DLP-flagged hold keeps its owner card; auto-send off keeps today's hold + card.plugins/social/test/: a fake client whosesend_as_memberreturnspending_approvaldrives the three cases — auto-send on → onedecide_approval approvedwith that id and no card; a DLP reason present → nodecide_approvaland the hold kept; auto-send off → no call.decide_approvalcalls; drop the DLP check → the second case fails with an approved hold.docs/subsystems/social.mdrecords that auto-send clears Bot Social's own hold only when it has no finding; one changelog fragment.ThinkFlowLab#737: Auto-send clears Bot Social's own hold, so the line…
fix(social): only the blanket Bot Social hold is cleared by Auto-send (…