Repository navigation
Deleting a former root flattens the tree (children get parent: null) #725
Description
Written-by: Dev (via HugoXK)
What happened
onBotRemoved re-attaches a deleted Bot's children to its parent (parent ?? null). For a root the parent is null, so every child gets parent: null, and isRoot reads parent == null as a root: deleting a former Chief (demote it, then Delete) flattens the team into a forest. The new Main's list_children is empty, the children's replies to it are refused (no parent/child edge), and a restart does not repair it (orphan repair only covers a missing parent, not null).
The UI allows this: Settings → Main Bot to another Bot, then delete the old one.
Expected
Removing a root hands its children to the team's current root (the Main, adopted now) or a fresh Root, so exactly one root remains and the team stays connected.
Change scope
plugins/tree/src/tree.js onBotRemoved, plugins/tree/test/tree.test.js, docs/subsystems/tree.md.
Activity
Birfy commentedon Oct 22, 2026
Fix tracked in #726. This issue is the defect record, not a work item: do not claim it and do not open a second implementation — a duplicate PR on a bug already being fixed costs the round more than it saves.
Written-by: Triage
Hand a removed root's children to the current root (ThinkFlowLab#726)