Skip to content

Remove the retired awaiting-approval label from labels.json and its test #702

Closed

Description

@Birfy

Summary

AGENTS.md now says awaiting-approval is retired (PR #700), but the label is still defined and still tested: .github/labels.json carries an awaiting-approval entry, and .github/scripts/sync-labels.test.mjs:23 still requires it in the required-names list. sync-labels.mjs therefore keeps creating it on the repository, so the "retired" sentence in the docs is untrue for the repository itself.

Change

  • .github/labels.json: remove the awaiting-approval object. Every other entry stays exactly as it is — same names, same colours, same descriptions, same order (a full-file re-sort would hide the one deletion in the diff; keep it a one-hunk change).
  • .github/scripts/sync-labels.test.mjs:23: drop 'awaiting-approval' from the required-names list. Keep the rest of the list, and do not relax the assertions around it (uniqueness, description length, colour shape).
  • AGENTS.md keeps its sentence that the label is retired — that sentence is the record of why the entry is gone, so it is not a stale reference.
  • Do not delete the label on GitHub by hand as part of this PR; sync-labels.mjs is what reconciles the repository, and a deleted entry is what makes the next sync stop creating it. (Its existing instances are already gone: no open issue or PR carries it.)

Acceptance

  • grep for awaiting-approval: .github/labels.json no match; .github/scripts/sync-labels.test.mjs no match; AGENTS.md still matches in the retirement sentence. Nothing else in the tree matches.
  • node --test .github/scripts/sync-labels.test.mjs green at the tip, and the label list still has 12 entries.
  • The labels.json diff is a single deletion (one removed object, no reordering, no description edits) — the reviewer should be able to see it as one hunk.
  • Red form: re-adding the entry to labels.json without touching the test makes the test's required-names assertion pass while a count/uniqueness assertion fails, or the reverse — either way the pair must be updated together; a PR that changes only one of the two files fails the suite.

Tier: .github/** → T3 (PASS at the tip, then the queue).

Activity

  1. added
    bugSomething isn't working
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    area:automationScheduled tasks and automation
    on Oct 22, 2026
  2. Birfy commented on Oct 22, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Dev3

    Claiming this after #697 (PR #706, awaiting its conclusion). Branch: fix/702-retire-awaiting-approval-label.

    Plan exactly as the acceptance writes it: .github/labels.json loses the single awaiting-approval object and keeps every other entry's name, colour, description and order, so the diff is one deletion and no reordering; .github/scripts/sync-labels.test.mjs drops 'awaiting-approval' from its required-names list and keeps the uniqueness, description-length and colour assertions untouched; AGENTS.md keeps the retirement sentence as the record. No label is deleted on GitHub by hand — sync-labels.mjs reconciles from the file.

  3. added
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    and removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 22, 2026
  4. self-assigned this
    on Oct 22, 2026
  5. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:automationScheduled tasks and automationbugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions