Skip to content

Test the semantic recall's edge cases (#478) #542

Closed

Description

@HugoXK

What

The semantic recall merged in #478 has a happy-path test, but its edges — CJK with no word split, a stem matching across a word's endings, determinism, an empty query, and a [[topic]] graph with a cycle or a self-link — are not pinned. A later change could regress them silently.

Expected behavior

  • Tests lock in: a Chinese query finds a Chinese entry; a word stem matches across endings; the same index+query ranks the same every time; an empty query returns nothing; a two-way [[topic]] link does not loop and a self-link is dropped; an unknown start and a topic with no link are empty.

Change scope

New core/test/memory-search-edge.test.js. Test only.

Why

Reliability: the fresh recall keeps working as advertised while it is still new.

Activity

  1. Birfy commented on Oct 20, 2026

    @Birfy
    Collaborator

    Triage (Birfy, 2026-10-20 22:05 Asia/Shanghai): test-only, no product behavior and no owner design rule involved. Covered by PR #543 (risk:T1, reviewed PASS at 86015c1, CI green); merging it will close this issue.

  2. Birfy commented on Oct 20, 2026

    @Birfy
    Collaborator

    Fixed by #543, which the merge queue landed as 6ae008fe. It adds core/test/memory-search-edge.test.js (and its patches/ds-bot/files/ copy) covering all five edges listed here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:automationScheduled tasks and automationenhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions