Skip to content

chore: 32 files cite #2684 for the Project-domain move; the issue is #2830 #2843

Closed

Description

@Birfy

Written-by: Chief

Owner: Dev
Reviewer: Reviewer

32 files cite #2684 for "the Project domain moved to plugins/project", but #2684 is "fix(workflow): refuse a store from a newer build instead of rewriting it" (closed 2026-11-08) and has nothing to do with the move. The issue that actually tracks it is #2830, which #2829 closes.

A reader following the citation in plugins/project/index.js:4, core/src/host/project-host.js:1 or docs/subsystems/project.md lands on an unrelated workflow-store fix. The same mistake was in #2829's body as Fixes #2684 and was corrected to Fixes #2830 before it merged.

Files (32, from code search for 2684 on main at 40f59a12)

Core and types: core/src/host/{constants,day-key,hooks,plugins,project-host,work-dir}.js, core/types/flybot.d.ts, core/test/{agents,install,project-domain,run-bot-tools}.test.js.
Docs and changelog: docs/subsystems/{core-host,plugin-runtime,project}.md, changelog.d/project-plugin.added.md.
Plugin: plugins/project/{index.js,client.js,README.md}, plugins/project/src/{host,install,project-metrics,project-state}.js, plugins/project/test/host.test.js.
Generated mirrors and the patch: patches/ds-bot/files/src/host/{day-key,hooks,plugins,project-host,work-dir}.js, patches/ds-bot/files/test/{project-domain.js,run-bot-tools.test.js}, patches/ds-bot/files/types/flybot.d.ts, patches/ds-bot/0002-flybot-api-host.patch.

Rule for the fix

Only rewrite a citation that means "the Project domain is a plugin now". Keep any genuine reference to #2684 (the workflow-store rule) exactly as it is — check the sentence around each hit, do not run a blind replace. The generated mirrors are not edited by hand: change core/ and the plugin, then node scripts/ds-bot-patches.mjs generate and confirm check and canonical are no-ops after it, so 0002-flybot-api-host.patch carries the same text.

Acceptance

  • node scripts/ds-bot-patches.mjs check and ... canonical both pass after generate.
  • git grep -n '#2684' leaves only hits that are truly about the workflow store (expected: none in plugins/project/ or the project docs).
  • npm --prefix core test is unaffected (comments only), and node core/scripts/check-arch-docs.mjs passes — use the Docs-not-needed: trailer if a comment-only edit to an owned file trips it.
  • No policy/ or workflow file is touched, so no Policy-sign:.

Why not now

Filed rather than dispatched with the README fix: it touches 32 files across core/, the plugin and the generated patch mirror, so it wants its own diff and its own review rather than riding a docs PR.

Activity

  1. added a commit that references this issue on Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:docsDocumentationdocumentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions