fix(workflow): Runs shows a failed last attempt twice (phantom Running + Failed) #1583

Written-by: Triage

Split from #1507 — the pinned half of its triage comment (2026-10-28T02:22Z). #1507 keeps the shape decision (group retries vs mark superseded); this one does not depend on it and ships regardless.

What happens

With no run active and a failed last attempt, Runs shows that same attempt twice: a phantom Running row plus its own Failed history row.

plugins/workflow/client.js on main 0e6dfc0d:

• liveStageRuns (:627-633) counts a run as live when run.live === true and its status is running or failed.
• runHistoryRows (:645-658) paints every row from liveStageRuns as status: 'running' (:650-654), then appends every workflow.history row (:656). A failed-live attempt is therefore listed once as Running and once as Failed.

Expected

One row per attempt. With no active run and a failed last attempt: exactly one row, labelled Failed, zero Running rows. A genuine retry still shows two distinguishable attempts — the retry is the live/current one, the earlier one stays Failed.

Scope (display only)

plugins/workflow/client.js — runHistoryRows (and liveStageRuns if the fix needs the run's own status). No src/service.js change for this half: lane.history already carries at, and that plus task.id is enough to tell a live failed attempt from its history row. No new state, no new key.

Red first

plugins/workflow/test/client.test.js already covers runHistoryRows (:906, :922) but only with running live runs. Add the failed case:

const task = { id: '#1422', title: 'PR 1422' }
const workflow = {
  activeCount: 0,
  queue: [],
  runs: [{ id: 'run-a', live: true, status: 'failed', task }],
  run: { id: 'run-a', live: true, status: 'failed', task },
  history: [{ task, status: 'failed', at: '2026-10-28T02:00:00Z' }],
}
const rows = client.runHistoryRows(workflow)
assert.equal(rows.length, 1)
assert.equal(rows[0].status, 'failed')
assert.equal(rows.filter(row => row.status === 'running').length, 0)

Red on base 0e6dfc0d (today it returns two rows, one running).

Acceptance

• The new case green; the existing runHistoryRows cases (:906, :922) and the runs tab shows one running row per concurrent live run (:934) stay green, so N concurrent live runs still render N rows.
• UI check on a workflow whose last attempt failed: Runs shows one Failed row and no Running phantom; a real retry then shows two distinguishable attempts with the newest current.

Risk

Client-only display fix inside plugins/workflow; no secrets and no permission surface. The controller decides the tier.