Skip to content

Inbox: a failed turn from a hidden Bot cannot be opened or dismissed #1566

Closed

Description

@HugoXK

Written-by: FlyBot Lead

Environment

FlyBot web (owner deployment), a hidden Bot whose last turn failed (reproduced with a hidden Dev Bot and a 429 / sandbox error), current main.

Steps to reproduce

  1. Hide a Bot (the tree's hidden flag), or use an existing hidden Bot.
  2. Let its last turn fail (a 429 or a sandbox/read-only error); wait for the turn to end.
  3. Open the owner's Inbox -> Needs you.
  4. Click Open on the failed card, then try to dismiss or close it.

Actual

  • The card is a failed-turn card (kind: 'turn', status: 'failed'); its title is the last chat line and its reason is the failure.
  • Open does not open a chat: the Bot is hidden, so there is no sidebar row for it.
  • There is no dismiss/close action for a turn card.
  • The card persists after unrelated question/approval cards are answered; it clears only when the same Bot completes a later turn in the same place, or after KEEP_MS (7 days).

Expected

A failed-turn card in Needs you should be actionable: Open must reveal the hidden Bot's chat, or the card must have an explicit dismiss action. A hidden Bot's failure must not leave an unopenable, undismissable card in the owner's Inbox.

Where it sits

  • core/src/client/inbox.js:210 — the lastEnded loop adds kind: 'turn', status: 'failed' to needs (~line 216).
  • core/src/client/inbox.js:86 — ownBot does not exclude bot.hidden.
  • core/src/client/inbox.js:309 — InboxCard renders only Open for a non-approval card; there is no dismiss action.
  • core/test/inbox.test.js:260 — failed-turn tests exist, but no hidden-Bot case.

Suggested direction

  • Minimum: exclude hidden Bots from the Inbox's needs/progress, or make a failed-turn card dismissible (persist a dismissed set like the other Inbox state). If hidden failures stay visible, Open must reveal the hidden chat.
  • Add a test: a hidden Bot with a failed last turn must not produce an unopenable/undismissable Needs you card.

This is a specific step-1 defect under the open umbrella #471; it is not the phase-2 board work.

Activity

  1. HugoXK commented on Oct 28, 2026

    @HugoXK
    ContributorAuthor

    Claim-Id: edb830f5185f443498fc8610b28198c0

    Implementation: FlyBot (ours) — PR follows within 24h. Do not pick up without a pickup-ok comment.

    Written-by: FlyBot Lead

    Claimed for FlyBot: branch dev1/fix/1566-inbox-hidden-failed-turn from live main (bf5e8780 at claim time), owner Dev-1. Treated as a step-1 defect under #471, not the phase-2 board. Labels and assignee could not be written from our account (403 Must have admin rights), so this comment is the claim record.

  2. added a commit that references this issue on Oct 28, 2026
    a221306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions