Repository navigation
fix(settings): Notifications first toggle row has no title #1492
Description
Problem
Written-by: FlyBotDebugger visual pass 5 (LIVE prod via cookie proxy)
Settings → General → Notifications: the first toggle row shows description only, with no title, while siblings have titles:
- (missing title) — “When your Bots finish, fail, or wait for your approval while you are in another chat or app.” + toggle
- Waiting for approval — “Once more if it still waits after 15 min.”
- Finished / Failed — title only
Expected
Every Notifications toggle row has a short title (e.g. “While away” / “In other chats”) plus optional description, matching the rows below.
Context
- Low priority polish; filed because the missing title is clear and stable
- Leave fix(host): a Workflow run Bot keeps the team tools, whatever the node's tools list says #1445 untouched; no prod-upgrade ask
- Search found no existing “Notifications missing title” issue
Screenshot
Owner
Birfy / bot-im
Activity
fix(workflow,settings): UI polish pass 5+6 - Progress button, Notific…
fix(workflow,settings): UI polish pass 5+6 - Progress button, Notific…
fix(workflow,settings): UI polish passes 4-6 - composer, locale, head…
Birfy commentedon Oct 28, 2026
Written-by: Triage
Already fixed and merged — no agent work needed, so this gets no
agent-ready.fix(workflow,settings): UI polish passes 4-6 …, merge commitcf72d48573b4b08d0f8546949a759a63bb132980, inmainsince 2026-10-27T18:40Z) fixed exactly this row: the first Notifications switch now carrieslabel: t('In other chats')—core/src/client/settings.js:77— with the string added incore/src/client/i18n.jsand a fragment atchangelog.d/1492-notifications-title.fixed.md. The row list atsettings.js:43-45(Waiting for approval/Finished/Failed) is unchanged and still titled, so the siblings match.mainat620235991e46c24836d03b16b76d642c9f7a4aa1:settings.jsat that tip contains the title, and thepatches/ds-bot/0014-flybot-branding.patchcopy carries it too.Fixes #1486, #1487, #1488, #1489, #1491, #1492, #1493, and GitHub closes only the number directly after the keyword, so#1486closed and the rest were linked, not closed. Closing this one now with the pull request named, as AGENTS.md requires for an issue left open by a merged PR.Labels left as they are (
bug,area:ui); closing rather than labelling, so nothing picks it up again.One note for the record, not a new defect: no test asserts the Notifications row titles —
In other chatsappears only insettings.js,i18n.js, the branding patch and the changelog fragment, so a future edit could drop a title again with CI green. That is a gap in #1494's coverage, not work left on this issue; say the word if a guard test is wanted and it can be filed separately.