You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
验收:docs/subsystems/live-e2e.md 那句改成“a bench home inside the checkout, or an --evidence directory under dev/live-e2e/”;同一次改动里对照 dev/live-e2e/README.md 的 path 表(那里已经区分对了),两处措辞一致。只改文档,guardRun 的行为不动。
Re-triaged at main 6d75f648. Confirmed on the tree: docs/subsystems/live-e2e.md:36 says “a bench home (or --evidence directory) inside the checkout” is refused, :49 repeats it — while dev/live-e2e/README.md:36 already draws the line correctly (home outside the checkout and never under ~/.dsh; --evidence refused only inside dev/live-e2e/), and nightly passes --evidence evidence, which is inside the checkout and outside dev/live-e2e/. So the page would fail its own documented command.
Fix: :36 and :49 become “a bench home inside the checkout, or an --evidence directory under dev/live-e2e/”, wording matched to the README path table; guardRunand the nightly workflow are not touched. Checks that must stay green:arch-docs` and the markdown link check on that page.
Owner: Dev4 — one docs PR together with #1184, both under docs/subsystems/. Reviewer: must not be Dev4.
Claimed by Dev4 — branch dev4/docs/1184-1180-doc-matches-code, cut from 6d75f648 (live main). One docs PR for #1184 + #1180, no code change: #1194 (tip 2785b5d4).
docs(subsystems): live-e2e 页把 --evidence 的拒绝范围写宽了,与 nightly 自相矛盾 #1180: docs/subsystems/live-e2e.md:35-38 — "a bench home (or --evidence directory) inside the checkout" → "a bench home inside this checkout, or an --evidence directory under dev/live-e2e/" (report.mjs:71), matching the invariant at :49-50 and dev/live-e2e/README.md:36.
Both close with the same merge (Fixes lines are separate, one per issue) so neither is left with an orphan branch.
Same PR, same merge: done — 7fae84e25779308d1d1d1c4ea33fb3c9e393b8ac. The wrap-up evidence (merge-commit file list, byte-identical blobs, the sentence on main vs report.mjs:71, labels) is written once on #1184: #1184 (comment)
Activity
Birfy commentedon Oct 25, 2026
Written-by: Triage
Re-triaged at
main 6d75f648. Confirmed on the tree:docs/subsystems/live-e2e.md:36says “a bench home (or--evidencedirectory) inside the checkout” is refused,:49repeats it — whiledev/live-e2e/README.md:36already draws the line correctly (home outside the checkout and never under~/.dsh;--evidencerefused only insidedev/live-e2e/), and nightly passes--evidence evidence, which is inside the checkout and outsidedev/live-e2e/. So the page would fail its own documented command.Fix:
:36and:49become “a bench home inside the checkout, or an--evidencedirectory underdev/live-e2e/”, wording matched to the README path table;guardRunand the nightly workflow are not touched. Checks that must stay green:arch-docs` and the markdown link check on that page.Owner: Dev4— one docs PR together with#1184, both underdocs/subsystems/.Reviewer:must not be Dev4.Birfy commentedon Oct 25, 2026
Claimed by Dev4 — branch
dev4/docs/1184-1180-doc-matches-code, cut from6d75f648(live main). One docs PR for #1184 + #1180, no code change: #1194 (tip2785b5d4).docs/subsystems/core-host.md:187— "only while the comment ispending" → "pending or unconfirmed" (tasks.js:401takes both).docs/subsystems/live-e2e.md:35-38— "a bench home (or--evidencedirectory) inside the checkout" → "a bench home inside this checkout, or an--evidencedirectory underdev/live-e2e/" (report.mjs:71), matching the invariant at:49-50anddev/live-e2e/README.md:36.Both close with the same merge (
Fixeslines are separate, one per issue) so neither is left with an orphan branch.Birfy commentedon Oct 25, 2026
Same PR, same merge: done —
7fae84e25779308d1d1d1c4ea33fb3c9e393b8ac. The wrap-up evidence (merge-commit file list, byte-identical blobs, the sentence on main vsreport.mjs:71, labels) is written once on #1184: #1184 (comment)docs: say what the write-back and evidence guards actually do (ThinkF…
docs: say signing is shipped and not enabled (ThinkFlowLab#1195) (Thi…