Skip to content

After friend accepts invite, inviter home shows no friend row / no joined feedback #1054

Closed

Description

@Birfy

Reproduce

Two fresh FlyBot homes on main b9a66e1 (SelfA1025 :3090 / SelfB1025 :3091 → https://47-80-69-220.sslip.io):

  1. On A: + → Add friend → Copy invite for Chief (SelfA1025).
  2. On B: paste invite → Accept.
  3. Observe B sidebar and A's sidebar / chat after accept.

Expected

Inviter (A) sees that the invite was accepted, and a clear path to share their Bot back / start mutual chat — or explicit UI copy that only the joiner can talk to the inviter's Bot (one-way by design). Silent zero feedback is not enough either way.

Actual

  • B sees "Chief (SelfA1025) · Friend's Bot" and can message A's Chief.
  • A's sidebar never shows a friend row for B / SelfB1025; A gets no "joined" / accept toast or row.
  • A cannot open a chat to message B. Messaging looks one-way with no explanation on the inviter side.
  • Design may intentionally be one-way grant (ST-F19: inviter direction has a grant; peer side stays 0 by design), but the UI gives zero feedback that accept happened and no way for the inviter to share back or understand the asymmetry.

Environment

  • SHA: b9a66e1e87133b3771ee63f01204c3546fee5490
  • Homes: SelfA1025 / SelfB1025 (fresh)
  • Social: https://47-80-69-220.sslip.io

Screenshots (on box; not uploaded)

  • /workspace/social-ui-deep-test/shots/04-A-invite-link.png — A Add-friend panel with invite link / "Invite link for Chief copied."
  • /workspace/social-ui-deep-test/shots/05-B-after-accept.png — B after accept: selected Chief (SelfA1025) Friend's Bot, empty chat.
  • /workspace/social-ui-deep-test/shots/07-A-received-failed.png — A after B accepted and messaged: inbound line from SelfB1025 on Chief, but no friend row for B in the sidebar.

Suggested scope

Needs-human — clarify the product rule in UI:

  • If mutual friendship is the goal: after accept, inviter gets a friend/person row + prompt to share their Bot / open chat both ways.
  • If one-way grant is the rule (ST-F19): inviter still needs accept confirmation + explicit copy ("SelfB can message Chief; share your Bot so you can message theirs") and a one-click share-back.

Not a duplicate of #970 (re-share after revoke never reaches friend).

Source

product UI deep-test 2026-10-25

Activity

  1. added
    bugSomething isn't working
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    area:socialFriends, invites, grants, Bot Social
    area:uiWeb/desktop UI and copy
    self-testFiled by the product self-test routine (issues only)
    on Oct 25, 2026
  2. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Needs-human: clarify mutual vs one-way grant in the inviter UI (related to ST-F19 one-way-by-design).

    • If mutual: after accept, inviter gets a friend/person row + share-back / chat path.
    • If one-way: inviter still needs accept confirmation + explicit copy that only the joiner can talk to the inviter's Bot, plus a one-click share-back.

    Not a duplicate of #970. Filed by product UI deep-test 2026-10-25; not claimed.

  3. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (recorded by Birfy): Keep one-way grant by default (inviter shares Bot; joiner sees Friend’s Bot).

    BUT the inviter MUST get visible feedback when someone accepts (toast and/or sidebar notice / friend activity), and a clear one-click path to share their Bot back / add mutual access. Do not leave the inviter with a silent empty sidebar.

    Not mutual-by-default; not silent asymmetry.

    Claimed by Birfy. Branch: birfy/fix/1054-inviter-accept-feedback, from main (will sync to tip). Flipping needs-human → agent-ready + agent-working.

    Written-by: Birfy

  4. added
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    and removed
    needs-humanThe agent loop stopped; a person must decide (reason in the last comment)
    on Oct 25, 2026
  5. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Closing for now per owner: findings not yet re-verified against social.botawaken.com. Will reopen only if confirmed on a fresh UI pass.

  6. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Closing at owner's request pending re-verification on social.botawaken.com — these findings may be false positives and are not yet confirmed.

  7. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 25, 2026
  8. 3 remaining items

  9. self-assigned this
    on Oct 25, 2026
  10. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Owner decision (2026-10-25): keep the one-way grant, but the inviter must see accept feedback plus a path to share back. Confirmed on reverify2: after B accepted, A still shows "Nobody has this Bot" and no friend row. Reopening; claimed by Birfy.

  11. added
    needs-infoWaiting for the reporter or a maintainer decision
    and removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 25, 2026
  12. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Written-by: Triage

    agent-working removed — nothing is being worked on this one (no owner branch, no PR), so it was reading as in-flight on the board while it was not.

    The repro is on main b9a66e1, which is now four merges behind c062fb02. Please re-run the same steps on current main before this goes to a Dev: a defect that only exists on a stale build costs a whole PR round.

    This one is held at needs-info rather than agent-ready: the symptom is the inviter-side outcome of accepting an invite, and two merges after your base changed exactly that — #1024 (1d5b5a5f) made the re-accept grant name the peer bot instead of the home and removed the friend_home fallback, and #1037 (699d03d9) fixed the Your … copy on the same line. If it still shows no friend row on c062fb02, say so here with the two sidebars and I will put agent-ready back the same round.

    Labels stay as they are if the re-run reproduces. If it does not, close it or move it to needs-info with what changed.

  13. added
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    and removed
    needs-infoWaiting for the reporter or a maintainer decision
    on Oct 25, 2026
  14. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Continue deep-test confirm (2026-10-25)

    Reconfirmed on https://social.botawaken.com: accepter sees "You already have Chief (SelfA1025). Your Chief is shared back…", but inviter sidebar still has no friend row for B. Owner asked to fix this track (already claimed). Not filing a duplicate for the "one-directional friendship UI" candidate.

  15. Birfy commented on Oct 25, 2026

    @Birfy
    CollaboratorAuthor

    Ark retest 2026-10-25

    Reconfirmed on social.botawaken.com with live Ark models: Accept still gives no toast; inviter A has no friend row for B. Already claimed/fixing — no new duplicate.

  16. added a commit that references this issue on Oct 25, 2026
    d5deea6
  17. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 25, 2026
  18. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:socialFriends, invites, grants, Bot Socialarea:uiWeb/desktop UI and copybugSomething isn't workingself-testFiled by the product self-test routine (issues only)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions