Skip to content

AGENTS.md:172 still says the team merges on the Birfy/FlyBot fork; it now goes upstream through the main merge queue #1015

Closed

Description

@Birfy

Owner: Dev

What is out of date

AGENTS.md:172 (main 9c3890a5) still opens with the old premise:

On the code fork Birfy/FlyBot, where this team's pull requests actually merge, the gate is a ruleset, not a queue (#812).

Pull requests no longer merge there. #1004 (v0.2.6) and #1009/#1010/#1011/#1013 all merged on upstream ThinkFlowLab/FlyBot through the main merge queue, whose ruleset requires three contexts — Node 24 · DSH 0.2.0-rc.2, tests-ok, merge-gate (:174 already says so). The fork is an archive; AGENTS.md:99 and docs/release-runbook.md were rewritten for that in #1013, so :172 is now the only place in the file that tells the reader the opposite.

Two sentences in that paragraph depend on the premise and are wrong as written:

  • "its main requires two checks, tests-ok and enqueue-guard, with bypass_actors: [], so PUT /pulls/<n>/merge is refused" — that describes the fork's protection, which is no longer the merge path;
  • "The order is not optional: the check must already report … before the ruleset goes on" — an instruction for applying a ruleset to the repository that merges, which is upstream today and not covered by merge-gate-ruleset.json.

Expected

A reader who only reads :172 learns the live path: a PR is opened upstream and enters the main merge queue (three required contexts); enqueue-guard still runs on the entry and still writes its check there, while the queue does not read that context — that part is what :174 (#960) explains and it stays true.

Scope

Acceptance

  1. grep -n "actually merge|code fork" AGENTS.md returns only lines that sit under the historical note (or nothing), and no line says the team's pull requests merge on Birfy/FlyBot.
  2. AGENTS.md:172 names the upstream queue and its three required contexts, and still explains enqueue-guard's entry behaviour and what it refuses (do not drop the list of refusals).
  3. gate-ruleset.mjs either no longer appears, or appears only as historical with the reason it is not part of publishing today; no instruction to run --apply/first-check-before-ruleset survives outside that note.
  4. Every internal anchor/link still resolves (node .github/scripts/check-arch-docs.mjs is the CI judge); Docs-not-needed: is not needed because docs/ does change.

Why it is not part of #1006 / #1013

#1013 rewrote docs/release-runbook.md and the daily-release row of AGENTS.md:99; the merge-plumbing paragraph :172 was out of its scope and is the last fork-first claim left in the repo's agent instructions.

Activity

  1. added
    documentationImprovements or additions to documentation
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 24, 2026
  2. self-assigned this
    on Oct 24, 2026
  3. Birfy commented on Oct 24, 2026

    @Birfy
    CollaboratorAuthor

    Claimed — Owner: Dev, one pull request: #1016 (docs/1015-agents-merge-gate-premise, tip e945cfb), one file, AGENTS.md only, from main 9c3890a5.

    • :172 no longer opens with the fork premise. It states the live path: pull requests merge upstream through the main merge queue, whose ruleset requires three contexts (Node 24 · DSH 0.2.0-rc.2, tests-ok, merge-gate), and it points at the The merge queue does not require enqueue-guard: a red guard cannot stop an entry, and the pass label is only a record #960 paragraph for how merge-gate reads the body.
    • enqueue-guard stays fully described: it writes its check on the head and on the queue entry, from code taken from main, on every event that can change the answer for a fixed head, calling the guard's own decision — and the refusal list is unchanged (hold, no PASS naming that tip, a PASS with no Ran:, no agent-pr, a body naming no issue).
    • The fork's own ruleset (tests-ok + enqueue-guard, bypass_actors: [], PUT refused) is now one clearly-labelled historical paragraph with the date, saying the fork is an archive, those contexts are not this repository's gate, and --apply/--rollback are not part of any routine — including the old "check on every open PR before the ruleset" ordering, which is described as that fork's alone.

    :99, :174 (#960) and :178 (hold) untouched; docs/ untouched, per scope. No changelog fragment (docs only).

    Written-by: Dev

  4. removed
    agent-workingAn agent has claimed this issue (the claim comment names the branch)
    on Oct 24, 2026
  5. Birfy commented on Oct 24, 2026

    @Birfy
    CollaboratorAuthor

    done — the four closing items are checked on merge commit c52a9ba5 (now main):

    Labels cleaned: #1015 → documentation|agent-ready|area:docs, #1016 → pass.

    The Reviewer's non-blocking (the no PASS naming that exact tip refusal is the T2/T3 rule; merge-gate.mjs's exemptFromPass needs no PASS for T0/T1) is written up as an issue rather than left in a comment.

    Written-by: Dev

  6. removed
    agent-readyMaintainer-approved spec: an agent may take it. Only maintainers set this; never in a template
    on Oct 24, 2026
  7. added 2 commits that reference this issue on Oct 24, 2026
    c52a9ba
    bb96c5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area:docsDocumentationdocumentationImprovements or additions to documentation

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions