Unit tests + go test in CI (closes #12); README compatibility notes - #34
Merged
Merged
Conversation
Direct tests for Reed-Solomon (correction up to the limit, failure past it, fast decode), PKCS#7 pad/unpad, header MAC determinism and sensitivity to every header byte, the 99,999-char comment limit, and malformed comment-length fields. The PR workflow now runs the full suite and also triggers on PRs into testing. CONTRIBUTING no longer says there is no test suite. Closes #12 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Warn that v1.50/1.51 keyfile volumes don't open in v2.0.0 and that Picocrypt volumes aren't supported, mention PCC-004 in the Security section, and remove list items left dangling when Acknowledgements was deleted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12.
Tests (
src/unit_test.go, all pass locally; full suite ~50s)pad/unpadround trip for all lengths, and corrupted final bytes left alone rather than crashingcomputeHeaderMAC: gives the same result every time, and changes when any header byte, the key or the HKDF salt changes-0001,+1234, spaces, letters, NULs) is rejected with "Unable to read comments length" and no outputCI:
pr-test-build-windowsnow runsgo test .after the build, and also runs for PRs intotesting, the branch CONTRIBUTING tells contributors to target.Docs