Conversation
Manifest and version info are now defined in src/winres/winres.json (RT_MANIFEST/RT_VERSION) alongside the existing icon entries, and patched into the built exe post-link via `go tool go-winres patch`. This drops the unversioned Resource Hacker zip download and five tool invocations separated by hardcoded Start-Sleep calls (3.5+ minutes per build), replacing them with one deterministic, checksum pinned Go tool dependency. The manifest can't be folded into the compile-time .syso like the icon is, because this project cgo-links via mingw, whose CRT auto-links its own default-manifest.o into GUI executables and conflicts with an embedded RT_MANIFEST at link time. Patching it in post-build sidesteps that. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Automatic triggers (push/pull_request) don't fire on this fork until approved in repo settings, so this workflow has never actually run. Manual dispatch lets it be validated without needing that approval or touching the release pipeline. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RT_MANIFEST) and version info (RT_VERSION) intosrc/winres/winres.json, alongside the existing icon entries.dist/windows/versioninfo.rcis removed (superseded).Start-Sleepcalls totaling 3.5+ min) with a singlego tool go-winres patch --in winres/winres.json --no-backup 1.exestep, usinggo-winrespinned as a checksummed Go tool dependency instead of an unversioned URL.upxcompression and the WiX MSI step are untouched.The manifest can't be folded into the compile-time
.sysothe way the icon is — this project cgo-links via mingw, whose CRT auto-links its owndefault-manifest.ointo GUI executables, which conflicts with an embeddedRT_MANIFESTat link time (ld: .rsrc merge failure: multiple non-default manifests). So the icon stays compile-time via.sysoas before, and the manifest + version info get patched into the already-linked exe post-build viago-winres patch— same post-link approach Resource Hacker used, just one deterministic call instead of five.Validated end-to-end on a real
windows-2025runner via manual dispatch: run 30731838971, 5m16s (vs. ~8-9 min previously) with icon,asInvokermanifest, and version info all correctly embedded.Fixes #13
Test plan
go build(icon via .syso) →go tool go-winres patch(manifest + version) produces an exe with correct icon (MAINICON/GLFW_ICON),asInvokermanifest, andFileVersionRaw/ProductVersionRaw=1.51.0.0.pr-test-build-windows.ymlpassed via manual dispatch onwindows-2025.