Conversation
The per-user (no-admin) install silently completed without actually installing anything - confirmed on a real machine, since nothing in this pipeline actually runs the installer (CI only builds it). Rather than keep debugging a less common, harder-to-test install path blind, switched to the standard per-machine pattern: installs to ProgramFiles64Folder, requires a UAC admin prompt during install. File association and context menu registry entries move from HKCU to HKCR, which Windows Installer resolves to HKEY_LOCAL_MACHINE\Software\Classes for a per-machine install - the correct root so these apply to every user on the machine, not just whoever happened to run the elevated installer. Also adds a Desktop shortcut alongside the existing Start Menu one. README updated to reflect that the installer (not the app itself) now requires administrator privileges.
Wires up WiX's standard WixUI_Minimal dialog set (license agreement, progress, and a "Setup was successful" completion screen) so the installer actually shows something at the end instead of finishing silently. There's no simpler built-in WiX dialog set that skips straight to a success screen - every stock sequence includes the license dialog first, which is normal practice for GPL software anyway, so this uses it as-is. License.rtf is a mechanically generated RTF conversion of LICENSE (plain-text GPL-3.0, escaped for RTF's special characters, verified brace-balanced). Also fixes a real bug found via install.log from actual testing: the app was landing in "C:\Program Files (x86)\ZeeCrypt" instead of "C:\Program Files\ZeeCrypt", because the wix build command never declared a target architecture, so WiX defaulted to a 32-bit package and Windows Installer's dual-folder redirection silently swapped ProgramFiles64Folder to the x86 path. Added -arch x64. .gitignore now covers *.msi/*.wixpdb/install.log, the local artifacts produced while testing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the MSI installer, confirmed working end-to-end on a real machine:
C:\Program Files (x86)\ZeeCryptinstead ofC:\Program Files\ZeeCryptbecause the wix build command never declared a target architecture. Added-arch x64.Already verified against the live v1.51 release assets (which this build also republished with the fixes) - confirmed working by direct install test.