Skip to content

#1046 Stale 'Teams are still loading.' status alert after a blocked press during the pending phase - #9

Merged
Tevin2119 merged 1 commit into
fix/mobile-board-exitfrom
delivery/1046-stale-teams-are-still-loading-status-ale-8bc6813438
Oct 7, 2026
Merged

Tevin2119 merged 1 commit into
fix/mobile-board-exitfrom
delivery/1046-stale-teams-are-still-loading-status-ale-8bc6813438

Conversation

@polymaniadeveloper-hub

Copy link
Copy Markdown
Collaborator

Task pingdotgg#1046, run run-8bc6813438. Approved by T for commit 7dc6bf8, which passed its checks and the QA gate.

What was asked

Found by qa-attack (zhipu) while testing task task-851d1c1114.

Steps: Run pnpm exec vp test run .qa/probe-stale.test.ts --config .qa/vp.config.ts. Enter Orchestrator mode, press Start while /api/teams is still pending (alert shows 'Teams are still loading.'), then let the reading answer [rnd, alpha].
Expected: Once the draft settles on rnd and Start is enabled, the status alert stops claiming teams are still loading.
Actual: The alert keeps showing 'Teams are still loading.' although activity.blocked is null and Start works; only save() clears problems. The alert span, problems state, and onStart's problem-setting are untouched by this diff, and the diff's reorder removes this staleness for the empty-list press path, so it is pre-existing residue.

  • Finding: find-273f0b0947, not blocking, out of scope of the task it was found on, not in the code that change delivered
  • Run: run-4b7a52aea4
  • Candidate tested: 4799c5e
  • Evidence: /Users/tevinmuparadzi/.paperclip/polymania/runs/run-4b7a52aea4/evidence

Done when

  1. In Orchestrator mode, after Start is requested while /api/teams is still pending and the alert shows 'Teams are still loading.', once the reading answers [rnd, alpha] and the draft settles on rnd, the status alert no longer shows 'Teams are still loading.'
  2. The same holds when a save request is made during the pending phase (through the draft store's requestSave, since the Save button is disabled then): once teams have loaded, the alert no longer shows 'Teams are still loading.'
  3. While /api/teams is still pending, a Start request still shows 'Teams are still loading.' in the status alert.
  4. After the teams load and the stale message is gone, pressing Start with text written starts the task as before.
  5. A problem returned by the engine on save or submit still stays in the alert until the next save or start attempt; it is not cleared by teams finishing loading.
  6. A focused test covers the pending-request-then-teams-load case and passes with pnpm exec vp test run apps/web/src/components/delivery/OrchestratorComposerControls.test.tsx.

Opened by the delivery engine after a person's approval. Merging is a separate step.

…uring the pending phase

The 'Teams are still loading.' notice is no longer stored in problems. The component records which thread's save or start was refused for loading and shows the notice only while that thread's draft is still blocked by loading (awaiting teams, environment connected, no read error, no availability reason). It therefore disappears when teams load, gives way to the empty-list message or a read error, and is not brought back by a later refresh. Engine problems are still kept until the next save or start attempt and are never classified by text. One alert span, same wording, same precedence. Nine new test cases cover both requestStart and requestSave; the ten existing tests are unchanged.

Task task-7551d03f55, revision 3, run run-8bc6813438.
@Tevin2119
Tevin2119 merged commit b3e96cd into fix/mobile-board-exit Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants