Repository navigation
#1046 Stale 'Teams are still loading.' status alert after a blocked press during the pending phase - #9
Merged
Tevin2119 merged 1 commit intoOct 7, 2026
Conversation
…uring the pending phase The 'Teams are still loading.' notice is no longer stored in problems. The component records which thread's save or start was refused for loading and shows the notice only while that thread's draft is still blocked by loading (awaiting teams, environment connected, no read error, no availability reason). It therefore disappears when teams load, gives way to the empty-list message or a read error, and is not brought back by a later refresh. Engine problems are still kept until the next save or start attempt and are never classified by text. One alert span, same wording, same precedence. Nine new test cases cover both requestStart and requestSave; the ten existing tests are unchanged. Task task-7551d03f55, revision 3, run run-8bc6813438.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task pingdotgg#1046, run run-8bc6813438. Approved by T for commit 7dc6bf8, which passed its checks and the QA gate.
What was asked
Found by qa-attack (zhipu) while testing task task-851d1c1114.
Steps: Run pnpm exec vp test run .qa/probe-stale.test.ts --config .qa/vp.config.ts. Enter Orchestrator mode, press Start while /api/teams is still pending (alert shows 'Teams are still loading.'), then let the reading answer [rnd, alpha].
Expected: Once the draft settles on rnd and Start is enabled, the status alert stops claiming teams are still loading.
Actual: The alert keeps showing 'Teams are still loading.' although activity.blocked is null and Start works; only save() clears problems. The alert span, problems state, and onStart's problem-setting are untouched by this diff, and the diff's reorder removes this staleness for the empty-list press path, so it is pre-existing residue.
Done when
Opened by the delivery engine after a person's approval. Merging is a separate step.