Repository navigation
#1083 chosenTeamUnavailable re-parses the teams body on every render - #31
Merged
polymaniadeveloper-hub merged 1 commit intoOct 13, 2026
Conversation
Removed redundant team parsing by passing the memoized teams to chosenTeamUnavailable. Preserved blocking messages, empty-list precedence and failure behavior. Task task-a4bb7fbb17, revision 2, run run-1e37df276f.
polymaniadeveloper-hub
merged commit Oct 13, 2026
983a86f
into
fix/mobile-board-exit
7 of 15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task pingdotgg#1083, run run-1e37df276f. Approved by T for commit 52a76ba, which passed its checks and the QA gate.
What was asked
Found by qa-attack (zhipu) while testing task task-8a53ca9f8c.
Steps: Open the composer in Orchestrator mode with any prompt and type; each keystroke re-renders OrchestratorComposerControls, whose teamAvailabilityReason now calls chosenTeamUnavailable(teamsRead, draft), and that function runs selectableTeams(read.body) (full parseTeam pass over every record) instead of reusing the memoized teams array the component already holds at OrchestratorComposerControls.tsx:68.
Expected: The already-memoized selectableTeams(teamsRead.body) result is reused, as the old expression did via the teams memo.
Actual: The whole teams body is re-parsed once per render. Cost is microseconds for realistic team lists, so no user-visible jank is expected; it is a redundant parse the change introduced.
Done when
Opened by the delivery engine after a person's approval. Merging is a separate step.