Repository navigation
chore: trim unreferenced docs assets and the SDK tarball - #466
Conversation
Mintlify loads every .js file under docs/ on every page, so docs/content/analytics.js shipped to each docs visitor although every line is a comment. docs/segment.js is the live analytics loader. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No tracked file on main names these images, including docs/openapi.json, the Postman collection, and the READMEs. No open PR or mcp-v2 branch adds a reference to one. The four routing screenshots lost their last reference when the map_geojson docs replaced them. Removes 4.2 MiB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EXECUTION_SUMMARY.md, IMPROVEMENT_PLAN.md, and TEST_RESULTS_V2.md describe the server on @modelcontextprotocol/sdk 0.5 and 1.20. The server now runs on the 2.x split packages. TESTING.md was the only other file that linked to them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The @terminal49/sdk tarball shipped compiled tests, type tests, test helpers, and the smoke and example scripts. It also shipped .map and .d.ts.map files whose sources point at src/, which the tarball does not include, so consumers' bundlers could not resolve them. - package.json files: exclude dist test, test-d, test helper, and scripts output. npm run build still compiles them, so the smoke and example scripts keep working from dist. - tsconfig.json: stop emitting sourceMap and declarationMap. Type declarations still emit. - Delete src/scripts/example-deserialize.ts. Nothing runs it. npm pack --dry-run: 214 files, 223.7 kB packed and 1.54 MB unpacked, down to 54 files, 109.8 kB and 748 kB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No workflow publishes it, the name is not on npm, and the MCP registry entry points at the hosted server. private: true stops an accidental npm publish. Release-please only rewrites its @terminal49/sdk dependency, which private does not affect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
public/ holds store-icons/ and sdks/typescript-sdk/src/fixtures/ holds 26 fixtures, so neither placeholder keeps an empty directory alive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
| }, | ||
| "files": [ | ||
| "dist/**/*" | ||
| "dist/**/*", |
There was a problem hiding this comment.
If a developer built the base branch before switching to this branch, rebuilding leaves the old .js.map and .d.ts.map files in dist. Disabling map output does not delete existing files, and "dist/**/*" still includes them. A local npm pack therefore still ships maps that point to missing source files.
Exclude map files explicitly or clean dist before building. The fresh checkout used by the publish workflow avoids this case.
| "dist/**/*", | |
| "dist/**/*", | |
| "!dist/**/*.map", |
Prompt To Fix With AI
This is a comment left during a code review.
Path: sdks/typescript-sdk/package.json
Line: 11
Comment:
**Old maps still ship**
If a developer built the base branch before switching to this branch, rebuilding leaves the old `.js.map` and `.d.ts.map` files in `dist`. Disabling map output does not delete existing files, and `"dist/**/*"` still includes them. A local `npm pack` therefore still ships maps that point to missing source files.
Exclude map files explicitly or clean `dist` before building. The fresh checkout used by the publish workflow avoids this case.
```suggestion
"dist/**/*",
"!dist/**/*.map",
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.There was a problem hiding this comment.
Fixed in d862ac4 with !dist/**/*.map in files. To check it, I created a stale dist/stale-dummy.js.map and dist/client/stale-dummy.d.ts.map. Before the change, npm pack --dry-run --workspace @terminal49/sdk listed both. After the change it lists no .map files, and the pack keeps its 54 files, including dist/index.js and dist/index.d.ts.
A dist built before source maps were disabled keeps its .map files, and dist/**/* would still pack them. Exclude them explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
What
Removes files that ship to users or sit in the repo without a reader, and stops the
@terminal49/sdktarball from carrying test and dev output. Each change is its own commit: docs, then SDK and MCP code, then tooling.docs:docs/content/analytics.js, a fully commented-out Segment snippet. Mintlify loads every.jsunderdocs/on every page.docs/segment.jsis the live loader.docs:docs/images/(4.2 MiB).docs(mcp):EXECUTION_SUMMARY.md,IMPROVEMENT_PLAN.md, andTEST_RESULTS_V2.md(October 2025 notes about MCP SDK 0.5 and 1.20), and theTESTING.mdlink to them.fix(sdk):src/. Delete the unusedsrc/scripts/example-deserialize.ts.chore(mcp):@terminal49/mcp"private": true.chore:public/.gitkeepandsdks/typescript-sdk/src/fixtures/.gitkeep. Both directories hold tracked files.SDK tarball
package.jsonfilesnow excludesdist/**/*.test.*,dist/**/*.test-d.*,dist/test, anddist/scripts.tsconfig.jsonno longer emitssourceMapordeclarationMap. The maps referenced../src/*.ts, which the tarball never included, so bundlers reported them as broken. The build itself is unchanged, sonpm run smokeandnpm run examplestill run fromdist/scripts. The publish workflow runs the samenpm run build.npm pack --dry-run --workspace @terminal49/sdkBefore, the 214 files were 54 library files, 42 test outputs (205 kB), 106 maps (575 kB), 8 script outputs, and 4 test-helper outputs. After, only the 54 library files remain:
dist/index.*,dist/client.*,dist/client/**,dist/generated/**,dist/types/**,README.md, andpackage.json.I checked the packed tarball from a clean consumer project.
npm install ./terminal49-sdk-0.6.0.tgzsucceeds.import('@terminal49/sdk')returnsTerminal49Client.tsc --strict --module nodenexttype-checksnew Terminal49Client({ apiToken })against the shipped.d.ts.Evidence for the deletions
unref.mjs(a script that lists tracked assets whose basename no other tracked text file mentions) reports these 14 onmain. I also searcheddocs/openapi.json, the Postman collection, and all 309 remote branches. Only stale branches reference any of them. The one open PR among them, [CHORE] add current status filter docs #221, hascarriers_screenshot.pngandnew_webhook.pngonly in its old base, and its diff againstmaindoes not add them. The four*_route*and*vessel_positions*screenshots lost their last reference in 28c2fe3 (Add map_geojson documentation). The docs site servesdocs/images/under/images/, so an external link to one of these URLs would now 404. I can't rule that out from the repo.TESTING.mdlinked to them, and that link is removed here. None of the three files is in the mcp-v2 stack diff.@terminal49/mcpprivate.npm view @terminal49/mcpreturns 404. No workflow publishes it. The MCP registry entry (server.jsonin the mcp-v2 stack) lists only the hosted remote. Release-please only rewrites its@terminal49/sdkdependency.npm install --package-lock-onlyleaves thepackages/mcplockfile entry unchanged.Verification
On this branch, Node 24.11.0:
npx vp run checknpx vp run testnpx vp run buildgit merge-treeagainst #458, #461, #462, #459, #465, andmcp-v2/08-releaseFollow-ups
ci.ymlstill has dead branch filters (cursor/vite-plus-toolchain-cdbd,master).ci.ymlis in the mcp-v2 stack diff and in chore(deps): update MCP, gateway, and SDK dependencies and clear npm audit #458, so this PR leaves it alone.packages/mcp/scripts/sdk-setup.mjspins@terminal49/sdk@0.2.0in itspublishedmode. The docs that describesdk:setupare in the mcp-v2 stack.main,npm installwith npm 11 rewritespackage-lock.jsoninto a lockfile thatnpm cirejects. It drops@modelcontextprotocol/sdkand@anthropic-ai/sdk, which are optional peers undermintlify. chore(deps): update MCP, gateway, and SDK dependencies and clear npm audit #458 removesmintlify. This PR does not touch the lockfile.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.The PR appears safe to merge, with a non-blocking cleanup needed for SDK packages made from previously built checkouts.
Fix with agent prompt
Summary
Removes unused docs assets and historical MCP notes, marks
@terminal49/mcpprivate, and trims the published SDK.Acknowledged by
dodeja: external links to the deleted images may return 404. The PR explicitly accepts this possibility because external use cannot be ruled out.Reviews (1) · Last reviewed commit: "chore: delete .gitkeep files from direct..." · Reviewed by Greptile