Repository navigation
Conversation
…ashboard Containers and shipments lists now add actively_tracked=true unless the caller sets actively_tracked or tracking_stopped, or passes include_stopped_tracking for history. Tool descriptions carry the dashboard definitions for ready for pickup, at risk and discharged-not-picked-up, and ask for the set's total before any narrowing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 7, 2026
alosec
marked this pull request as ready for review
October 7, 2026 18:28
maurycy
approved these changes
Oct 7, 2026
maurycy
left a comment
maurycy
left a comment
Contributor
There was a problem hiding this comment.
The actively tracked default is consistent with operational worklists and preserves explicit tracking filters. Approved; clarifying stopped-only queries and adding historical-query evaluations would be useful follow-ups.
sinankeskin
approved these changes
Oct 7, 2026
Contributor
Author
|
(Codex) @maurycy clarified historical versus stopped-only queries, added passing SDK request regressions, and added historical/stopped-only agent-eval cases as follow-up coverage with live runs still pending. |
maurycy
approved these changes
Oct 8, 2026
maurycy
left a comment
maurycy
left a comment
Contributor
There was a problem hiding this comment.
Approved. The historical versus stopped-only behavior is clarified and covered by SDK request regressions.
* feat(mcp): list_parties resolves company names to party IDs
list_parties turns a company name (customer, shipper, consignee, broker,
forwarder, dray carrier) into the party ID that advanced_filters.parties
needs, with one call to GET /v2/parties?query=. Rails already searches
company names there (whole words and word prefixes, ignoring case); the
OpenAPI spec didn't document the param, so the SDK and MCP couldn't use
it.
- OpenAPI: document query on GET /parties; SDK types regenerated.
- SDK: parties.list accepts { query } (PartyListOptions).
- MCP: list_parties passes search through and reports meta.total and
truncated.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* chore: Auto-generate Postman collection from openapi.json [skip ci]
* docs(api): correct party search and tracking-request examples
* fix(mcp): page party matches and retain disambiguation context
* chore: regenerate party API types and reference artifacts
* chore: Auto-generate Postman collection from openapi.json [skip ci]
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Member
|
@claude rebase |
Contributor
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of the #398 split. Base
mcp-preview(Akshay's verified filters, #397).What changes
list_containersandlist_shipmentsaddactively_tracked: trueunless the caller setsactively_tracked/tracking_stoppedor passesinclude_stopped_tracking: true(for history such as past pickups or dwell). The tool descriptions carry the dashboard's definitions and ask for the set's total first:current_status: availablerequires_attention: true, sortattention_priority(the Containers at Risk view)available,not_available,grounded,awaiting_inland_transferNo Rails change: both filters already exist. The dashboard applies the tracked filter on every worklist; the MCP didn't.
Evidence (one change, one measurement)
Starter chips on staging Sodor, 5 chips × 3 runs, Braintrust project AskT49:
starter-chips-v1-filters-20261006)starter-chips-v1-tracked-default-20261006)The arm-C run is exactly this commit (no compact rows, no summarize). Totals before and after on the same question:
Demurrage trace: one call,
list_containers {requires_attention: true, sort: attention_priority}, sentactively_tracked: trueand readmeta.total: 1359.Risk
History questions now need
include_stopped_tracking: true; the description says so. The contract helper ignores the default so an unfiltered list isn't reported as filtered.Tests
390 MCP tests pass; type check and lint clean.
🤖 Generated with Claude Code
Historical queries now explicitly include both active and stopped records; stopped-only queries use
actively_tracked: false(or shipmenttracking_stopped: true). SDK request tests preserve these distinctions, and historical/stopped-only agent cases are added onfeat/askt49-eval-runneras follow-up coverage; live runs remain pending.