Skip to content

TD-7588 Issue showing console 403 error when try to launched the self… #3758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sherif-olaboye wants to merge 1 commit into
base: DLS-Release-v1.3.3
Choose a base branch
from
Open

TD-7588 Issue showing console 403 error when try to launched the self… #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion DigitalLearningSolutions.Web/ServiceFilter/RequireProcessAgreementFilter .cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ public void OnActionExecuting(ActionExecutingContext context)
logger.LogWarning(
$"Attempt to access self assessment {selfAssessmentId} by user {delegateUserId}, but no such assessment found"
);
context.Result = new RedirectToActionResult("StatusCode", "LearningSolutions", new { code = 403 });
controller.TempData["ErrorMessage"] = "The self-assessment cannot be launched because no competencies have been marked as required.";
context.Result = new RedirectToActionResult("Current", "LearningPortal", null);
return;
}
if (!selfAssessment.IncludeLearnerDeclarationPrompt) return;
Expand Down
17 changes: 16 additions & 1 deletion DigitalLearningSolutions.Web/Views/LearningPortal/Current/Current.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,21 @@
<div class="nhsuk-grid-column-full">
<h1 id="page-heading">My Current Activities</h1>

@if (TempData["ErrorMessage"] is string errorMessage)
{
<div class="nhsuk-error-summary" aria-labelledby="error-summary-title" role="alert" tabindex="-1">
<h2 class="nhsuk-error-summary__title" id="error-summary-title">
There is a problem
</h2>
<div class="nhsuk-error-summary__body">
<div class="nhsuk-u-padding-top-1 nhsuk-u-padding-bottom-3">
<span class="error-message--margin-bottom-1 nhsuk-error-message">
<span>@errorMessage</span>
</span>
</div>
</div>
</div>
}
@if (!Model.ApiIsAccessible)
{
<vc:learning-resource-warning css-class="nhsuk-u-margin-bottom-4 nhsuk-u-margin-top-4"
Expand Down Expand Up @@ -73,6 +88,6 @@
@if (Model.JavascriptSearchSortFilterPaginateEnabled)
{
@section scripts {
<script src="@Url.Content("~/js/learningPortal/current.js")" asp-append-version="true"></script>
<script src="@Url.Content("~/js/learningPortal/current.js")" asp-append-version="true"></script>
}
}
Loading