Skip to content

Add platform-specific helper text for Dolphin path setting - #393

Merged
matellush merged 1 commit into
TeamWheelWizard:devfrom
swindlesmccoop:fix/dolphin-executable-helper-text
Sep 9, 2026
Merged

matellush merged 1 commit into
TeamWheelWizard:devfrom
swindlesmccoop:fix/dolphin-executable-helper-text

Conversation

@swindlesmccoop

@swindlesmccoop swindlesmccoop commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Purpose of this PR:

Fix misleading Dolphin executable helper text on Linux and macOS. The empty-state message previously read as Path must end with .exe, which only applies to Windows.

How to Test:

  1. Unset the Dolphin binary/command in your configuration
  2. Open Settings --> Location Settings
  3. Observe the new helper text

What Has Been Changed:

Before:
image
After:
image

Related Issue Link:

N/A

Checklist before merging

  • You have created relevant tests

Manual verification is fine I think, as there aren't any major changes in behavior to validate

Summary by CodeRabbit

  • New Features
    • Added platform-specific guidance for selecting the Dolphin executable in Settings.
    • Linux users now receive guidance for selecting the executable file.
    • macOS users now receive guidance for selecting Dolphin.app.
    • Windows guidance remains available when no executable is configured.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 5a8ce3c4-6e10-4344-85f2-4a79836d2d8f

📥 Commits

Reviewing files that changed from the base of the PR and between 86618e7 and 9733c32.

📒 Files selected for processing (3)
  • WheelWizard/Resources/Languages/en.yml
  • WheelWizard/Views/Pages/Settings/WhWzSettings.axaml
  • WheelWizard/Views/Pages/Settings/WhWzSettings.axaml.cs
💤 Files with no reviewable changes (1)
  • WheelWizard/Views/Pages/Settings/WhWzSettings.axaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The settings page now displays platform-specific Dolphin executable guidance. English localization adds Linux and macOS helper text. The settings code selects the appropriate text and applies it when no executable path is configured.

Changes

Dolphin helper text

Layer / File(s) Summary
Platform-specific helper text selection
WheelWizard/Resources/Languages/en.yml, WheelWizard/Views/Pages/Settings/WhWzSettings.axaml, WheelWizard/Views/Pages/Settings/WhWzSettings.axaml.cs
English localization adds Linux and macOS guidance. The settings page sets helper text programmatically and selects the text by operating system, with Linux as the fallback.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 9733c

When no Dolphin path is configured, Location Settings now shows guidance appropriate to Windows, Linux, or macOS. The change is limited to localized helper text and its display logic, with no remaining merge-readiness risk identified.

Suggested reviewers: dirkdoes, patchzyy

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description includes all required sections, explains the platform-specific helper text change, provides manual testing steps, and documents that no related issue applies. The unchecked test checkl…
Title check ✅ Passed The title clearly and concisely describes the main change: adding platform-specific helper text for the Dolphin path setting.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit hops through settings bright
To choose the helper text just right
Linux speaks, macOS too
Windows keeps its wording true
Dolphin paths now guide the night

Comment @coderabbitai help to get the list of available commands.

@matellush
matellush changed the base branch from main to dev September 9, 2026 09:46
@matellush
matellush merged commit a851c7b into TeamWheelWizard:dev Sep 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants