[v8] grouped row selection/deselection is not working properly  #4349

Activity

1. ludydoo commented on Feb 16, 2023

   

   ludydoo

   on Feb 16, 2023

   More actions

   A workaround I found for this is to

   • Not use the info.table.toggleAllRowsExpanded()
   • Instead, use

   const allSelected = info.table.getIsAllRowsSelected();
   for (const row of info.table.getRowModel().flatRows) {
       row.toggleSelected(!allSelected);
   }
   
2. alexbezhan commented on Apr 19, 2023

   

   alexbezhan

   on Apr 19, 2023

   Last edited by alexbezhan

   More actions

   My workaround:

   1. toggleAllRowsSelectedHandler() that uses expanded row model
   2. getIsAllRowsSelected() that uses expanded row model

   function getIsAllRowsSelected(table: Table<any>) {
       // implementation is a copy from the Tanstack table implementation, except we use expanded row model to work properly with grouped rows
       const rows = table.getExpandedRowModel().rows
       const { rowSelection } = table.getState()
   
       let isAllRowsSelected = Boolean(
           rows.length && Object.keys(rowSelection).length
       )
   
       if (isAllRowsSelected) {
           if (
               rows.some(
                   row => row.getCanSelect() && !rowSelection[row.id]
               )
           ) {
               isAllRowsSelected = false
           }
       }
   
       return isAllRowsSelected
   }
   
   function getToggleAllRowsSelectedHandler(table: Table<any>) {
       return () => {
           const newRowSelection = { ...table.getState().rowSelection }
           const newSelected = !getIsAllRowsSelected(table)
   
           if (newSelected) {
               for (const row of table.getExpandedRowModel().rows) {
                   if (!row.getCanSelect()) {
                       continue
                   }
                   newRowSelection[row.id] = true
               }
           } else {
               for (const row of table.getExpandedRowModel().rows) {
                   if (!row.getCanSelect()) {
                       continue
                   }
                   delete newRowSelection[row.id]
               }
           }
           table.setRowSelection(newRowSelection)
       }
   }
   
3. lattemisa commented on Aug 15, 2023

   

   lattemisa

   on Aug 15, 2023

   More actions

   Hello, I am still facing this issue, was this ever resolved?
4. KevinVandy commented on Jul 27, 2026

   

   KevinVandy

   on Jul 27, 2026

   Member

   More actions

   Group-row selection IDs are independent by design. Descendant checkbox state is meant to be set via getIsAllSubRowsSelected/getIsSomeSelected
5. KevinVandy

   closed this as completedon Jul 27, 2026