fix(solid-query): use QueryClient from query-core - #8943
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 08ddaa8.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8943 +/- ##
===========================================
+ Coverage 44.07% 79.33% +35.25%
===========================================
Files 200 14 -186
Lines 8021 329 -7692
Branches 1761 62 -1699
===========================================
- Hits 3535 261 -3274
+ Misses 4058 56 -4002
+ Partials 428 12 -416
🚀 New features to boost your workflow:
|
Contributor
|
Sizes for commit 08ddaa8:
|
Collaborator
|
I think now you can't set |
Member
Author
|
Why is that option exclusive to solid? Would it make sense to have it in query-core, with test coverage? |
Collaborator
|
I don’t know what it does, it seems to be specific to solid, which is why it was living in the adapter. I think we might need to revert this PR to avoid breaking the public API. |
birkskyum
added a commit
that referenced
this pull request
Apr 3, 2025
…docs (#8950) * Revert "fix(solid-query): keep solid-query on just `createQuery` syntax (#8947)" This reverts commit 4e45d7c. * Revert "fix(solid-query): use QueryClient from query-core (#8943)" This reverts commit 8f84606. * deprecate create types * add proper deprecation * add solid reference * add solid guides * request waterfall and advanced ssr * client-state * ci: apply automated fixes * ci: apply automated fixes (attempt 2/3) --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.