docs(preact-query): remove hover-prefetch example from 'useQuery'/'useInfiniteQuery' - #11341
Conversation
|
View your CI Pipeline Execution ↗ for commit 0e8ab8f
☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe Preact ChangesPreact query documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change removes misleading hover-prefetch examples from the Preact Query documentation without changing published runtime behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Changeset Version Preview1 package(s) bumped directly, 24 bumped as dependents. 🟩 Patch bumps
|
size-limit report 📦
|
🎯 Changes
useQueryanduseInfiniteQueryeach had a hover-prefetch@example(Warming the cache on hover, so <Post>/<Comments> has data as soon as it's clicked) where the hook itself was used in one line, while the rest of the example (PostLink,useQueryClient,queryClient.query/queryClient.infiniteQuery) demonstrated a different, imperative API rather than the hook the example is documenting.The cache-sharing fact these examples existed to convey is already stated by the
@see {@link queryOptions}/@see {@link infiniteQueryOptions}lines already present on every overload of both hooks.useQuery.ts: removed the hover-prefetch example (the overload it was on keeps its other example)useInfiniteQuery.ts: same (the overload it was on keeps its other 3 examples)docs/framework/preact/reference/functions/*.mdfiles withpnpm run generate-docs✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit
useQueryanduseInfiniteQueryAPI documentation.skipTokenexample.