chore(preact-query): remove eslint-disable comments for rules already off at the package level by sukvvon · Pull Request #11275 · TanStack/query

sukvvon · 2026-08-24T18:47:55Z

🎯 Changes

packages/preact-query/eslint.config.js already sets no-unused-vars and @typescript-eslint/no-unnecessary-condition to 'off' at the package level, which makes the corresponding eslint-disable-next-line comments in HydrationBoundary.tsx and utils.ts dead — eslint --skip-nx-cache reported both as "Unused eslint-disable directive". Removed both.

Left the two react-hooks/exhaustive-deps warnings in utils.ts untouched — that file is a direct port of React's use-sync-external-store shim, and adding _instance to those effect dependency arrays would introduce a feedback loop.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally with pnpm run test:pr.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Removed obsolete linting suppressions.
- No changes to hydration, snapshot comparison, error handling, or end-user functionality.

… off at the package level

coderabbitai · 2026-08-24T18:48:16Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 141650f0-56dd-440d-b9cc-6966d4e83643

📥 Commits

Reviewing files that changed from the base of the PR and between 96f2da6 and a9d7994.

📒 Files selected for processing (2)

packages/preact-query/src/HydrationBoundary.tsx
packages/preact-query/src/utils.ts

💤 Files with no reviewable changes (2)

packages/preact-query/src/HydrationBoundary.tsx
packages/preact-query/src/utils.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.

📝 Walkthrough

Walkthrough

Removed two obsolete ESLint suppression comments in preact-query. Hydration fallback handling and snapshot comparison behavior remain unchanged.

Changes

ESLint suppression cleanup

Layer / File(s)	Summary
Remove obsolete suppressions `packages/preact-query/src/HydrationBoundary.tsx`, `packages/preact-query/src/utils.ts`	Removed suppressions for the `state.queries

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to a9d79

This change only removes redundant lint suppression comments and does not alter published or runtime behavior; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the removal of obsolete ESLint disable comments in the preact-query package.
Description check	✅ Passed	The description explains the changes, preserves relevant warnings, completes all template sections, and records testing and release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch chore/preact-query-remove-dead-eslint-disables

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-24T18:49:03Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

nx-cloud · 2026-08-24T18:50:07Z

View your CI Pipeline Execution ↗ for commit a9d7994

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 45s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	8s	View ↗

☁️ Nx Cloud last updated this comment at 2026-08-24 18:56:26 UTC

pkg-pr-new · 2026-08-24T18:50:58Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11275

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11275

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11275

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11275

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11275

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11275

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11275

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11275

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11275

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11275

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11275

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11275

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11275

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11275

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11275

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11275

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11275

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11275

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11275

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11275

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11275

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11275

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11275

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11275

commit: a9d7994

github-actions · 2026-08-24T18:51:21Z

size-limit report 📦

Path	Size
react full	11.97 KB (0%)
react minimal	8.92 KB (0%)

chore(preact-query): remove eslint-disable comments for rules already…

a9d7994

… off at the package level

sukvvon self-assigned this Aug 24, 2026

sukvvon merged commit 9484a89 into main Aug 24, 2026
9 checks passed

sukvvon deleted the chore/preact-query-remove-dead-eslint-disables branch August 24, 2026 19:03

sukvvon mentioned this pull request Aug 24, 2026

chore(scripts/create-github-release): fix release-notes diff range after 'Version Packages' PR is squash-merged #11279

Merged

4 tasks

Navigation Menu

Uh oh!

Uh oh!

chore(preact-query): remove eslint-disable comments for rules already off at the package level - #11275

chore(preact-query): remove eslint-disable comments for rules already off at the package level#11275
sukvvon merged 1 commit into
mainfrom
chore/preact-query-remove-dead-eslint-disables

sukvvon commented Aug 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 24, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

nx-cloud Bot commented Aug 24, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Aug 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 24, 2026

🚀 Changeset Version Preview

Uh oh!

nx-cloud Bot commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Aug 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 24, 2026 •

edited

Loading

nx-cloud Bot commented Aug 24, 2026 •

edited

Loading