fix(preact-query/usePrefetchQuery): replace deprecated 'queryClient.fetchQuery' with 'queryClient.query' - #11274
Merged
sukvvon merged 2 commits intoAug 24, 2026
Conversation
…etchQuery' with 'queryClient.query'
|
View your CI Pipeline Execution ↗ for commit ab98b72
☁️ Nx Cloud last updated this comment at |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthrough
ChangesPreact query prefetch migration
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This is a localized replacement of a deprecated prefetch API with its intended successor, plus release metadata; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Changeset Version Preview1 package(s) bumped directly, 24 bumped as dependents. 🟩 Patch bumps
|
Contributor
size-limit report 📦
|
sukvvon
deleted the
fix/preact-use-prefetch-query-deprecated-fetch-query
branch
August 24, 2026 19:06
Merged
4 tasks
DogPawHat
reviewed
Aug 25, 2026
| const client = useQueryClient(queryClient) | ||
|
|
||
| if (!client.getQueryState(options.queryKey)) { | ||
| void client.fetchQuery(options).catch(noop) |
Contributor
There was a problem hiding this comment.
Whoops. That should have been query when I filed #10669
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
usePrefetchQueryin@tanstack/preact-querystill calledqueryClient.fetchQuery, which is@deprecatedin favor ofqueryClient.query.react-query'susePrefetchQueryalready usesclient.query, and preact-query's ownusePrefetchInfiniteQueryalready usesclient.infiniteQuery— this closes the last remaining spot using the deprecated method.Swaps the call from
client.fetchQuery(options)toclient.query(options). No behavior change:query()performs the same staleness check, retry default, and cache build asfetchQuery(); its only addition is runningselecton the returned promise, which prefetch discards.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Documentation