Skip to content

fix(intent): make first-run permission selection compact - #243

Merged
LadyBluenotes merged 3 commits into
mainfrom
fix/installer-package-picker
Sep 5, 2026
Merged

fix(intent): make first-run permission selection compact#243
LadyBluenotes merged 3 commits into
mainfrom
fix/installer-package-picker

Conversation

@LadyBluenotes

Copy link
Copy Markdown
Member

🎯 Changes

First-run intent install printed every discovered skill description before asking for input. A project with 14 packages and 82 skills produced roughly 27 KB of text before the first choice.

Replace that dump with a count summary and searchable package picker showing at most six options. Review puts selected packages first and lets users choose individual skills, inspect descriptions and exclusions, or view the exact configuration before saving. Allow-all remains a separate advanced choice with explicit confirmation.

Also reject empty search results before submission, remove the duplicate completion message, and update the install, configuration, and trust documentation.

Follow-up to #241. The original installer is unreleased, so this updates its existing minor changeset instead of adding a separate patch entry. The broader scopes of #221, #222, and #234 remain open.

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm run test:pr.

Validation: 601 unit tests and 73 integration tests passed, along with lint, typecheck, docs checks, and build. Final focused checks passed all 198 installer/CLI tests. Tested the 14-package/82-skill example in a terminal: search, package-to-individual selection, configuration preview without writes, and saving five exact permissions plus guidance. changeset status confirms one minor release and no patch release.

🚀 Release Impact

  • This change affects published code; the existing unreleased installer changeset is updated.
  • This change is docs/CI/dev-only (no release).

@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 43 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 97e5cac4-e596-4be9-82e2-6741fe4082ee

📥 Commits

Reviewing files that changed from the base of the PR and between 4e59119 and c4dc0d6.

📒 Files selected for processing (13)
  • .changeset/fair-tools-review.md
  • docs/cli/intent-install.md
  • docs/concepts/configuration.md
  • docs/concepts/trust-model.md
  • docs/getting-started/quick-start-consumers.md
  • packages/intent/src/commands/install/command.ts
  • packages/intent/src/commands/install/package-json.ts
  • packages/intent/src/commands/install/permission-prompts.ts
  • packages/intent/src/commands/install/permissions.ts
  • packages/intent/tests/cli.test.ts
  • packages/intent/tests/install-writer.test.ts
  • packages/intent/tests/permission-prompts.test.ts
  • packages/intent/tests/permissions.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 1c7f6aa

Command Status Duration Result
nx run-many --targets=build ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-05 02:42:47 UTC

@nx-cloud

nx-cloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 776c0ad

Command Status Duration Result
nx run-many --targets=build ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-05 01:58:29 UTC

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@243

commit: c4dc0d6

@LadyBluenotes
LadyBluenotes merged commit 126a286 into main Sep 5, 2026
9 checks passed
@LadyBluenotes
LadyBluenotes deleted the fix/installer-package-picker branch September 5, 2026 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant