[BUG][1.9.0~1.9.2] Unexpected database file deletion on backup deletion #64

Activity

1. Fallen-Breath

   closed this as completedon Mar 29, 2025
2. Fallen-Breath

   changed the title [-][BUG] Unexpected database file deletion on backup deletion[/-] [+][BUG][1.9~1.9.2] Unexpected database file deletion on backup deletion[/+] on Mar 29, 2025
3. Fallen-Breath

   added

   bugSomething isn't workingSomething isn't working

   on Mar 29, 2025
4. Fallen-Breath

   pinned this issue on Mar 29, 2025
5. Fallen-Breath

   added

   data securityAffects data security / completeness of existing backupsAffects data security / completeness of existing backups

   on Mar 29, 2025
6. Fallen-Breath commented on Mar 29, 2025

   

   Fallen-Breath

   on Mar 29, 2025

   Last edited by Fallen-Breath

   ContributorAuthor

   More actions

   Source: https://t.bilibili.com/1049779707586805763

   Translated to English using AI:

   Basic Information

   • Affected Versions: 1.9.0 ~ 1.9.2
   • Fixed Version: 1.9.3
   • Trigger Scenario: Backup deletion operations, including manual deletion and automatic cleanup.

   Scope of Impact

   • When deleting a backup, the data of backups that share the same base fileset with that backup will also be deleted.
   • New backups are not affected.
   • Backups created or deleted after upgrading to v1.9.3 are not affected.

   Damage Results

   • Affected backups will become incomplete, losing >= 80% of their files.

   Verification Method

   Use the !!pb database validate filesets command for self-inspection. If the output shows a mismatch, as in the example provided, it is affected

   Example output:

   1. 399: fileset.file_object_count 11075 != actual file object count 265
   

   Fileset 399 is damaged, and backups that reuse fileset 399 are all affected.

   (Requires plugin v1.9.4+) You can check the pb_files/logs/validate.log log and look for the line with "Affected backup IDs (bad filesets)" to determine the scope of impact.

   Repair Method

   Cannot be repaired. Restoration must rely on additional backups outside of PB (such as PB’s own database backups, blob store backups, etc.) to the best extent possible.

   For affected backups:

   • If not needed, they can be ignored or deleted
   • If restoration is desired, it is necessary to collect as many backups of the database and the blob store (pb_files/blobs) as possible. I will provide a data recovery tool to do the best possible restoration later (see [BUG][1.9.0~1.9.2] Unexpected database file deletion on backup deletion #64 (comment))

   Note: Prime Backup v1.9.0 was released on March 15, 2025, 14 days ago.
7. Fallen-Breath

   added a commit that references this issue on Mar 29, 2025

   The #64 fixer

   27891a8
8. Fallen-Breath

   changed the title [-][BUG][1.9~1.9.2] Unexpected database file deletion on backup deletion[/-] [+][BUG][1.9.0~1.9.2] Unexpected database file deletion on backup deletion[/+] on Mar 29, 2025
9. Fallen-Breath

   added a commit that references this issue on Mar 29, 2025

   The #64 fixer

   0194a6e
10. Fallen-Breath commented on Mar 29, 2025

    

    Fallen-Breath

    on Mar 29, 2025

    Last edited by Fallen-Breath

    ContributorAuthor

    More actions

    fixer script

    Note

    You need to have external backups of these 2 stuffs perform the fix:

    1. Backup of the database file (created by PB v1.9+). Take a look in pb_files/db_backup
    2. (Optional) Backup of the blob store (pb_files/blobs) backups

    No rescue if no backup :(

    Script: https://github.com/TISUnion/PrimeBackup/blob/dev/tools/issue_64_fixer.py

    Usage: https://github.com/TISUnion/PrimeBackup/blob/dev/tools/README.md#issue_64_fixerpy
11. hi54123 commented on Jun 22, 2025

    

    hi54123

    on Jun 22, 2025

    More actions

    刚想来说我存档炸了，结果就有了（